Closed
Conversation
bonjourmauko
added
level:intermediate
benjello
requested changes
Sep 24, 2024
Member
benjello
left a comment
benjello
left a comment
There was a problem hiding this comment.
IMHO it is definitely a major bump
CHANGELOG.md
Outdated
| @@ -1,5 +1,17 @@ | |||
| # Changelog | |||
|
|
|||
| ## 41.6.0 [#1228](https://github.com/openfisca/openfisca-core/pull/1228) | |||
Member
There was a problem hiding this comment.
assert_near is a public tool used by many other packages.
It is a major version bump.
setup.py
Outdated
| setup( | ||
| name="OpenFisca-Core", | ||
| version="41.5.5", | ||
| version="41.6.0", |
Member
There was a problem hiding this comment.
IMHO it should be a major bump
Member
Author
Could you check, in the _parsers and _assertions files, if that corresponds to the intended behaviour? The string evaluation works, I fixed some bugs when dealing with non-evaluated strings. |
Member
Looks good to me, but for safety check you should run this on the |
bonjourmauko
force-pushed
the
fix/openfisca-test
branch
from
9c701eb to
9880dc1
Compare
Ndpnt
force-pushed
the
fix/openfisca-test
branch
from
d0b53e5 to
46fcb74
Compare
github-project-automation
bot
moved this from Reviewing
to Abandoned
in OpenFisca International
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1316
Dependas on #1309
New features
openfisca_test.assert_nearandparseto prepare tests.Technical changes
assert_near.