Skip to content

Update python version to 3.12.3 #1289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
May 2, 2025
Merged

Update python version to 3.12.3 #1289

merged 7 commits into from
May 2, 2025

Conversation

benoit-cty
Copy link
Contributor

@benoit-cty benoit-cty commented Nov 5, 2024

This PR will close #1287

OpenFisca-core is working with Python 3.12 since the version 43, but allowed minimal Numpy version, 1.24, do not work with Python 3.12.

So this PR change matrix test to only test Numpy version 1.26.4 with Python 3.12, and 1.24.2 + 1.26.4 for Python 3.9.13.

@benoit-cty benoit-cty marked this pull request as ready for review April 29, 2025 09:06
@benoit-cty benoit-cty changed the title Draft : Update python version to 3.12.3 Update python version to 3.12.3 Apr 29, 2025
@benoit-cty benoit-cty requested a review from benjello April 29, 2025 09:10
@benjello
Copy link
Member

When/How do you think this can be solved @benoit-cty ? Seems to be a problem with GCC version.

@benoit-cty
Copy link
Contributor Author

benoit-cty commented Apr 29, 2025

EDIT : cache problem fixed, it was a missing activate_command parameter. But even after fixing it there was an error only on Python 3.13 for missing pytest.

I try to add Python 3.13 support but there is a problem with the cache:

Cache not found for input keys: pip-build-ubuntu-22.04-np1.26.4-py3.13.3-99de4728a41d1a653d50a01c32a197e60559a3cc7aa62537e00d48fad8142129-5fba06695a6bad9edd8f07d69d20b1f196402b35

Note:
The GitHub Actions cache for pip-build is not being created or restored for Python 3.13.3 (pip-build-ubuntu-22.04-np1.26.4-py3.13.3-...).
This works for Python 3.9.13 and 3.12.3, but for 3.13.3, the workflow shows a "Path Validation Error"—the files or directories expected for caching do not exist at the time the cache step runs.
The pip-deps cache is present for 3.13.3, so the issue is specific to the build cache.
This is likely due to a difference in the build or install process for Python 3.13.3, possibly related to dependency or compatibility issues.

Also, there is a GCC error in Windows.

Test 3.13

3.13.3 for Ubuntu

Explicit Numpy version

Add build deps for Python 3.13

debug

Try to fix "Error when evaluating"

Remove 3.13

debug

Add activate_command

3.13 OK
@eraviart eraviart self-requested a review May 2, 2025 12:40
Copy link
Member

@eraviart eraviart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

J'ai un peu peur que cela rallonge les tests, mais puisqu'on me dit que c'est nécessaire.

@benoit-cty
Copy link
Contributor Author

J'ai un peu peur que cela rallonge les tests, mais puisqu'on me dit que c'est nécessaire.

Normalement il doit y avoir moins de test qu'avant puisque la version 1.24 de Numpy n'est plus testée sur la version maximale de Python qui devient la 3.12 et n'est pas ajoutée en plus de la 3.11 mais la remplace.

@benoit-cty benoit-cty merged commit 5fbe31b into master May 2, 2025
23 checks passed
@benoit-cty benoit-cty deleted the python3.12 branch May 2, 2025 12:57
@Shamzic
Copy link

Shamzic commented May 5, 2025

Hello @benoit-cty, le déploiement a échoué (l'erreur semble liée aux métadonnées avec pyproject.toml ?).

@benoit-cty
Copy link
Contributor Author

En effet, c'était un problème de version de Twine : #1328

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update upper Python version to Python 3.12
4 participants