Implement onUncaughtError event for thread pools
#1777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `completed` variable is only set if the final job succeeds, but we want to clean up even if it fails.
This restores the behavior of `onError` to what it was in 8.1.0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This handles errors thrown from the other thread. In 8.1.0 and earlier, such errors weren't handled at all. In 8.2.0 prior to this PR, we caught the errors and dispatched them as
onErrorevents.This PR distinguishes the two sources of error (
throwandsendError()), and also enables the user to get the stack trace for a thrown error.If the user doesn't add a listener, we instead use
Log.error()to ensure that something shows up in the console. (We don't want to suddenly start hiding errors.)