Android: Use SCREEN_ORIENTATION_FULL_USER instead of SCREEN_ORIENTATI… #1835
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ON_FULL_SENSOR For Resizable Window. Fixes openfl#1737 Pulled from libsdl-org/SDL#10046
Member
|
Just adding some notes. This change has been added into both SDL3 and SDL2. It looks like, at the time that I'm writing this, it hasn't been included in an SDL2 release, but it's in the SDL2 branch of the repo. Assuming that SDL2 is still getting occasional new releases, it may make sense to wait until they release this update (and to wait until Lime updates its SDL submodule to that same version). I'm not sure how far our SDLActivity has deviated from the official, if it has at all, but ideally, we'd keep changes as close to official releases as possible. |
Member
|
SDL has been updated to 2.30.12 in the 8.3.0-Dev branch, and I can see that it includes this change. Closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ON_FULL_SENSOR For Resizable Window.
Fixes #1737
Pulled from libsdl-org/SDL#10046