Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Promise.completeAsync(). #1838

Open
wants to merge 4 commits into
base: 8.3.0-Dev
Choose a base branch
from

Commits on Aug 28, 2024

  1. Store the job's thread in JobData.

    Since we're storing more and more in `JobData`, and the background thread only needs three bits of that data, I added those to `ThreadEvent` so we don't have to pass the full object. This may improve performance in HTML5 specifically, where passing a class instance incurs an overhead.
    player-03 committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    c8e5611 View commit details
    Browse the repository at this point in the history

Commits on Sep 2, 2024

  1. Configuration menu
    Copy the full SHA
    0859148 View commit details
    Browse the repository at this point in the history
  2. Implement Promise.completeAsync().

    Compared to `new Future()`, this offers:
    
    - The option to run on the main thread.
    - The option to send progress events.
    - The ability to interrupt the job by calling `promise.error()`.
    player-03 committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    bfcd17c View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    2f71a64 View commit details
    Browse the repository at this point in the history