Enable stereo spatialization when using OpenAL Soft#2034
Open
Digivorix wants to merge 1 commit intoopenfl:8.4.0-devfrom
Open
Enable stereo spatialization when using OpenAL Soft#2034Digivorix wants to merge 1 commit intoopenfl:8.4.0-devfrom
Digivorix wants to merge 1 commit intoopenfl:8.4.0-devfrom
Conversation
Relies on the AL_SOFT_source_spatialize extension.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By default, OpenAL Soft will only allow spatialization on mono sounds. This means that the position property of Lime AudioSource instances has no effect if the audio is stereo. This change makes use of the AL_SOFT_source_spatialize extension to enable the spatialization of stereo audio sources along with mono ones when using OpenAL Soft.
According to the extension documentation, the stereo audio will be down-mixed to mono, but only if the audio has a non-0 distance from the listener, so stereo audio that is left at the default position should not be affected by this change.
I feel like most people will be using stereo audio sources, so enabling spatialization of these samples where possible makes sense.
Credit to @ACrazyTown for helping me out with this on the Haxe Discord and directing me to their PR (#2001) as an example of how to work with OpenAL extensions.