Fix GL objects not getting GC'd on HL#2039
Merged
dimensionscape merged 1 commit intoopenfl:developfrom Mar 9, 2026
Merged
Conversation
Member
|
Good catch! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Hashlink, prior to this change, no OpenGL objects would be cleaned up by the GC.
This was caused because the object was keyed by its
void*pointer, but the finalizer would receive aHL_CFFIPointer*and thus the map check would fail. To fix it I added a HL specific GC method that takes in aHL_CFFIPointer*and then retrieves the actual object pointer, to use for the map checks.