Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Also sync products that are no longer sold ("obsolete") #281

Closed
raphodn opened this issue Apr 29, 2024 · 3 comments · Fixed by #552
Closed

Also sync products that are no longer sold ("obsolete") #281

raphodn opened this issue Apr 29, 2024 · 3 comments · Fixed by #552

Comments

@raphodn
Copy link
Member

raphodn commented Apr 29, 2024

Story

Some products that are added on Open Prices appear as "no longer sold" on Open Food Facts.
But the OFF API only returns "currently sold" products, so we don't fetch any information for the "no longer sold" / archived products.

Example

For example : 3596710346561 : Open Food Facts / Open Prices

image

Related issues

@stephanegigandet
Copy link

@raphodn products that are marked "no longer sold" are returned by the API: https://world.openfoodfacts.org/api/v3/product/3596710346561/sauce-tomate-poivron-aubergine-auchan

@raphodn raphodn changed the title Also sync products that are no longer sold Also sync products that are no longer sold ("obsolete") May 2, 2024
@raphodn
Copy link
Member Author

raphodn commented May 2, 2024

@raphodn products that are marked "no longer sold" are returned by the API: https://world.openfoodfacts.org/api/v3/product/3596710346561/sauce-tomate-poivron-aubergine-auchan

After discussion on Slack, the obsolete products are indeed available in the API and in the CSV export, but not in the JSONL export. And there is no easy way to identify them.

An idea would be to have a seperate export with only obsolete products : see openfoodfacts/openfoodfacts-server#8338

@raphodn
Copy link
Member Author

raphodn commented Nov 7, 2024

This issue is not blocked anymore !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants