Skip to content

taxonomy: Taxonomy/improve taxonomies for croatia #11850

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
May 5, 2025

Conversation

benbenben2
Copy link
Collaborator

What

Add translations using taxonomy enhancer

Related issue(s) and discussion

  • Fixes #-none-

@benbenben2 benbenben2 requested a review from a team as a code owner May 2, 2025 12:56
@github-actions github-actions bot added 🧬 Taxonomies https://wiki.openfoodfacts.org/Global_taxonomies 🧪 additives 🥜 Allergens 📦 Packaging https://wiki.openfoodfacts.org/Category:Recycling 🧪 tests 🥗🔍 Ingredients analysis https://wiki.openfoodfacts.org/Ingredients_Extraction_and_Analysis Ingredients processing labels May 2, 2025
@github-project-automation github-project-automation bot moved this to In progress in Ingredient analysis May 2, 2025
@github-project-automation github-project-automation bot moved this to To discuss and validate in 🍊 Open Food Facts Server issues May 2, 2025
@codecov-commenter
Copy link

codecov-commenter commented May 2, 2025

Codecov Report

Attention: Patch coverage is 28.57143% with 5 lines in your changes missing coverage. Please review.

Project coverage is 50.29%. Comparing base (e8deee5) to head (bcdf681).
Report is 134 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
lib/ProductOpener/Ingredients.pm 28.57% 4 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11850      +/-   ##
==========================================
+ Coverage   49.88%   50.29%   +0.40%     
==========================================
  Files          83       84       +1     
  Lines       22984    23117     +133     
  Branches     5508     5532      +24     
==========================================
+ Hits        11466    11626     +160     
+ Misses      10121    10072      -49     
- Partials     1397     1419      +22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link

sonarqubecloud bot commented May 2, 2025

@@ -2602,6 +2606,9 @@ Text to analyze
if (defined $labels_regexps{$ingredients_lc}) {
# start with uncomposed labels first, so that we decompose "fair-trade organic" into "fair-trade, organic"
foreach my $labelid (reverse @labels) {
# Skip processing if the labelid is "organic"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why was this code added?

Copy link
Contributor

@stephanegigandet stephanegigandet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@github-project-automation github-project-automation bot moved this from To discuss and validate to Done in 🍊 Open Food Facts Server issues May 5, 2025
@github-project-automation github-project-automation bot moved this from Todo to In Progress in 📦 Packaging improvements May 5, 2025
@github-project-automation github-project-automation bot moved this from In progress to Reviewer approved in Ingredient analysis May 5, 2025
@stephanegigandet stephanegigandet merged commit daf606f into main May 5, 2025
14 checks passed
@github-project-automation github-project-automation bot moved this from Reviewer approved to Done in Ingredient analysis May 5, 2025
@github-project-automation github-project-automation bot moved this from In Progress to Done in 📦 Packaging improvements May 5, 2025
@stephanegigandet stephanegigandet deleted the taxonomy/improve-taxonomies-for-croatia branch May 5, 2025 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧪 additives 🥜 Allergens 🥗🔍 Ingredients analysis https://wiki.openfoodfacts.org/Ingredients_Extraction_and_Analysis Ingredients processing 📦 Packaging https://wiki.openfoodfacts.org/Category:Recycling 🧬 Taxonomies https://wiki.openfoodfacts.org/Global_taxonomies 🧪 tests
Projects
Status: Done
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants