-
-
Notifications
You must be signed in to change notification settings - Fork 469
fix: Lacto-ovo-vegetarian taxonomy #11852
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #11852 +/- ##
==========================================
+ Coverage 49.88% 50.29% +0.40%
==========================================
Files 83 84 +1
Lines 22984 23119 +135
Branches 5508 5532 +24
==========================================
+ Hits 11466 11628 +162
+ Misses 10121 10072 -49
- Partials 1397 1419 +22 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
2e37e89
to
ceb2b18
Compare
fd70d33
to
6c6fb26
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not too sure about the "Contains milk" label. It's not really a label, if we want to find products that contain milk, then using the ingredients en:milk tag is the way to go.
@stephanegigandet Is it possible to have (I also realise that this would all be better once we store derived and actually entered items separately, but I’m not sure how far off in the future that is, ie., whether to wait for this to manifest.) |
Currently the lacto- and ovo-vegetarian labels both derive from lacto-ovo-vegetarian, which will almost always be wrong. Ovo-vegetarians consume eggs but not dairy, while lacto-vegetarians consume dairy but not eggs—ovo-lacto-vegetarians consume both dairy and eggs. This makes the `en:Ovo-lacto-vegetarian` labels instead be a parent of `en:Lacto-vegetarian` and `en:Ovo-vegetarian` instead, since anything that is either lacto- or oco-vegetarian will also be ovo-lacto-vegetarian. `en:Ovo-lacto-vegetarian` is additionally made a child of `en:Vegetarian` since the ovo/lacto modifier adds additional restrictions, so vegetarians who still consume non-human animal byproducts (like dairy and eggs) will be fine with this.
6c6fb26
to
aab7d08
Compare
I took out the |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you
🤖 I have created a release *beep* *boop* --- ## [2.66.0](v2.65.0...v2.66.0) (2025-05-13) ### Features * Add weight % for single-item packaging ([#11855](#11855)) ([bcdb799](bcdb799)) * adding button to report image on view image page ([#11849](#11849)) ([a4390a5](a4390a5)) * Use multiplication symbol for packaging counts ([#11857](#11857)) ([2d65a1c](2d65a1c)) ### Bug Fixes * Lacto-ovo-vegetarian taxonomy ([#11852](#11852)) ([19ddf31](19ddf31)) * remove 250 and more for search size ([#11856](#11856)) ([89d96cf](89d96cf)) * Tests fail when run locally ([#11864](#11864)) ([e8ed7bd](e8ed7bd)) * text extraction issue for CZ and LT ([#11877](#11877)) ([22fd44d](22fd44d)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Currently the lacto- and ovo-vegetarian labels both derive from lacto-ovo-vegetarian, which will almost always be wrong. Ovo-vegetarians consume eggs but not dairy, while lacto-vegetarians consume dairy but not eggs—ovo-lacto-vegetarians consume both dairy and eggs.
This makes the
en:Ovo-lacto-vegetarian
labels instead be a parent ofen:Lacto-vegetarian
anden:Ovo-vegetarian
instead, since anything that is either lacto- or oco-vegetarian will also be ovo-lacto-vegetarian.en:Ovo-lacto-vegetarian
is additionally made a child ofen:Vegetarian
since the ovo/lacto modifier adds additional restrictions, so vegetarians who still consume non-human animal byproducts (like dairy and eggs) will be fine with this.