fix: add an explanation for the missing value and unit to a product #11998
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-project-automation
bot
moved this to To discuss and validate
in 🍊 Open Food Facts Server issues
github-project-automation
bot
moved this to Todo
in 🌐 Review & Merge translations across Open Food Facts
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## main #11998 +/- ##
==========================================
+ Coverage 49.88% 52.37% +2.48%
==========================================
Files 83 86 +3
Lines 22984 23118 +134
Branches 5508 5552 +44
==========================================
+ Hits 11466 12108 +642
+ Misses 10121 9450 -671
- Partials 1397 1560 +163 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
po/common/common.pot
Outdated
| @@ -7491,6 +7491,11 @@ msgctxt "action_report_image_to_nutripatrol" | |||
| msgid "Report this image to our moderators" | |||
| msgstr "Report this image to our moderators" | |||
|
|
|||
| msgctxt "missing_value_and_or_unit" | |||
There was a problem hiding this comment.
It's better to name it missing_serving_size_value_and_or_unit.
po/common/common.pot
Outdated
| @@ -7491,6 +7491,11 @@ msgctxt "action_report_image_to_nutripatrol" | |||
| msgid "Report this image to our moderators" | |||
| msgstr "Report this image to our moderators" | |||
|
|
|||
| msgctxt "missing_value_and_or_unit" | |||
| msgid "We are missing the serving size value and or unit to calculate the NutriScore" | |||
There was a problem hiding this comment.
``
Suggested change
| msgid "We are missing the serving size value and or unit to calculate the NutriScore" | |
| msgid "We are missing the serving size value and/or unit to calculate the Nutri-Score" |
github-actions
bot
added
🧪 tests
Attributes
tests/unit/attributes.t
Outdated
| lc => "en", | ||
| categories => "biscuits", | ||
| categories_tags => ["en:biscuits"], | ||
| nutrition_data_per_serving => "20", |
There was a problem hiding this comment.
Should be nutrition_data_per => "serving", and then you pass serving_size => "20 g" (or "20" or nothing depending on the case you want to test)
added 2 commits
June 13, 2025 10:33
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Add an explanation for the issues that we have a wrong message when we don't have value or unit for a product
Related issue(s) and discussion