fix: add an explanation for the missing value and unit to a product

[RayanGoubet]

What

Add an explanation for the issues that we have a wrong message when we don't have value or unit for a product

Related issue(s) and discussion

• Fixes If the serving size is incorrect, the KP should provide a better explanation #11322

[codecov-commenter]

Codecov Report

❌ Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 52.10%. Comparing base (e8deee5) to head (40d5d37).
⚠️ Report is 401 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
lib/ProductOpener/Display.pm	0.00%	4 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #11998      +/-   ##
==========================================
+ Coverage   49.88%   52.10%   +2.21%     
==========================================
  Files          83       90       +7     
  Lines       22984    24057    +1073     
  Branches     5508     5782     +274     
==========================================
+ Hits        11466    12535    +1069     
+ Misses      10121     9903     -218     
- Partials     1397     1619     +222     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[stephanegigandet]

It's better to name it missing_serving_size_value_and_or_unit.

[stephanegigandet]

``

Suggested change

	msgid "We are missing the serving size value and or unit to calculate the NutriScore"
	msgid "We are missing the serving size value and/or unit to calculate the Nutri-Score"

[stephanegigandet]

Looks good, but we should add a test that show the result of your changes. For instance in test/unit/attributes.t : add a product where we have serving size nutrients, but not the serving size.

[stephanegigandet]

Should be nutrition_data_per => "serving", and then you pass serving_size => "20 g" (or "20" or nothing depending on the case you want to test)

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[stephanegigandet]

I wrongly suggested to add a test in attributes.t : the change you made is not visible in attributes, only in the knowledge panels...