Skip to content

taxonomy: Tidy up “Puffed salty snacks (potato/soy based)” #12027

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Freso
Copy link
Collaborator

@Freso Freso commented Jun 14, 2025

Tacite and Olaf Görlitz made observations in Slack[1] that “Puffed salty snacks (potato/soy based)” had some wrong translations, seemed to be identical to “Puffed salty snacks made from potato and soy”, and also probably the wrong parent for “Cheese doodles”.

This merges “Puffed salty snacks (potato/soy based)” into “Puffed salty snacks made from potato and soy”, moves some translations from “Puffed salty snacks (potato/soy based)” to “Puffed salty snacks”, and sets the parent for “Cheese doodles” to be “Cheese puff pastries”.

[1]
https://openfoodfacts.slack.com/archives/C02VDSWHT/p1749725199812599
https://openfoodfacts.slack.com/archives/C02VDSWHT/p1749725219150049
https://openfoodfacts.slack.com/archives/C02VDSWHT/p1749725226999759
https://openfoodfacts.slack.com/archives/C02VDSWHT/p1749853184771419

Tacite and Olaf Görlitz made observations in Slack[1] that “Puffed salty
snacks (potato/soy based)” had some wrong translations, seemed to both
be identical to “Puffed salty snacks made from potato and soy”, and also
probably the wrong parent for “Cheese doodles”.

This merges “Puffed salty snacks (potato/soy based)” into “Puffed salty
snacks made from potato and soy” and sets the parent for “Cheese
doodles” to be “Cheese puff pastries”.

[1]
https://openfoodfacts.slack.com/archives/C02VDSWHT/p1749725199812599
https://openfoodfacts.slack.com/archives/C02VDSWHT/p1749725219150049
https://openfoodfacts.slack.com/archives/C02VDSWHT/p1749725226999759
https://openfoodfacts.slack.com/archives/C02VDSWHT/p1749853184771419
@github-actions github-actions bot added 🧬 Taxonomies https://wiki.openfoodfacts.org/Global_taxonomies categories labels Jun 14, 2025
@github-project-automation github-project-automation bot moved this to To discuss and validate in 🍊 Open Food Facts Server issues Jun 14, 2025
Copy link

@Freso Freso enabled auto-merge (squash) June 14, 2025 11:44
@Freso Freso moved this to Needs review in Product Opener Weekly Review Jun 14, 2025
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 50.95%. Comparing base (b35c436) to head (3e7531c).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #12027   +/-   ##
=======================================
  Coverage   50.95%   50.95%           
=======================================
  Files          86       86           
  Lines       23116    23116           
  Branches     5551     5551           
=======================================
  Hits        11778    11778           
  Misses       9895     9895           
  Partials     1443     1443           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@stephanegigandet stephanegigandet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@Freso Freso merged commit f607a7f into openfoodfacts:main Jun 18, 2025
18 checks passed
@github-project-automation github-project-automation bot moved this from To discuss and validate to Done in 🍊 Open Food Facts Server issues Jun 18, 2025
@github-project-automation github-project-automation bot moved this from Needs review to Done in Product Opener Weekly Review Jun 18, 2025
@Freso Freso deleted the taxonomy/puffed-salty-snacks-potato-soy branch June 18, 2025 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
categories 🧬 Taxonomies https://wiki.openfoodfacts.org/Global_taxonomies
Development

Successfully merging this pull request may close these issues.

3 participants