text_sam: Fixed issue when passing PIL Image as input to SamGeo2#370
Merged
giswqs merged 1 commit intoopengeos:mainfrom Nov 18, 2024
Merged
text_sam: Fixed issue when passing PIL Image as input to SamGeo2#370giswqs merged 1 commit intoopengeos:mainfrom
giswqs merged 1 commit intoopengeos:mainfrom
Conversation
Member
|
@cwhite911 Thank you for the fix. I just released a new version that includes this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm adding a GRASS addon i.sam2 and found this bug during implementation. The issue occurs when you pass a PIL Image as input to
LangSAM.predict. During this case the image source is not set. However, this causes an issue whenLangSam.predict_samis called throwing a value error inSamGeo2.set_image.