fix schema recursive references #371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pvretano @jerstlouis |
pvretano
approved these changes
Oct 30, 2023
|
@bpross-52n can this be considered before the next submission to OAB? |
|
I think this Closes #368 too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #370
When using
$schema: "https://schemas.opengis.net/ogcapi/processes/part1/1.0/openapi/schemas/process.yaml"at the top of theEchoProcessdefinition in my IDE, eachschemaunder each I/O are flagged as "missing required$ref". This seem to be caused be the duplicate nestedoneOfboth includingreference.ymlin each brahch.With this fix, using temporarily
$schema: "https://raw.githubusercontent.com/crim-ca/ogcapi-processes/fix-schema-recursive/openapi/schemas/processes-core/process.yaml",schemais properly resolved, and all I/Oschemaare considered valid forEchoProcess.