Reintroduce isort in the pre-commit #1145
Conversation
|
Task linked: QF-5224 Reintroduce isort in the pre-commit |
ruff.toml
Outdated
| @@ -20,6 +20,7 @@ exclude = [ | |||
| target-version = "py310" | |||
|
|
|||
| [lint] | |||
| select = ["I"] | |||
There was a problem hiding this comment.
I believe we don't need this one.
There was a problem hiding this comment.
The issue here, as mentioned in the description, is that ruff along with isort seems to break. I added select = ["I"] to let Ruff handle import sorting natively (as it supports this kind of rules - check here, which improves both performance and dependencies reduction. However, if keeping isort separately offers more, I’m happy to revert it!
There was a problem hiding this comment.
See what I meant in the call earlier. https://docs.astral.sh/ruff/configuration/#python-file-discovery
There was a problem hiding this comment.
So we need extend-select I guess..
There was a problem hiding this comment.
Test it, I guess that too.
There was a problem hiding this comment.
Yes, it works fine.
A problematic test file has been created:
Run adding extend-select:
Afterwards:
|
Please do a separate commit fixing all already existing errors with isort in the codebase and we are good to merge. |
tdrivas
force-pushed
the
QF-5224_Reintroduce_isort_in_the_pre-commit
branch
from
4baae28 to
5acc8ec
Compare
|
There are conflicts in the PR and it is still WIP, shall I really review? |
tdrivas
force-pushed
the
QF-5224_Reintroduce_isort_in_the_pre-commit
branch
from
5acc8ec to
5311540
Compare
tdrivas
changed the title
Auto-sort imports using Ruff instead of isort Replace select with extend-select for isort-based sorting of imports Fix import applying isort via pre-commit Fix conflicting files
tdrivas
force-pushed
the
QF-5224_Reintroduce_isort_in_the_pre-commit
branch
from
6789d1f to
5dc11ce
Compare
Ready to go! |
This PR integrates isort via
ruffusingextend-select. Instead of adding isort separately in pre-commit and dependencies, this PR utilizesruff's built-in import sorting by extending its configuration.Changes in This PR
ruffusingextend-select = ["I"]in ruff.tomlHow to Test
pre-commit run --all-filesBefore
After
