Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an assert when resending confirmation email #1160

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add an assert when resending confirmation email #1160

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions docker-app/qfieldcloud/core/views/accounts_views.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ def resend_confirmation_email(request: HttpRequest) -> HttpResponse:
if request.method != "POST":
return redirect_to_referer_or_view(request, "account_login")

assert "account_verified_email" in request.session
email_address = request.session.get("account_verified_email")
Comment on lines +38 to 39
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
assert "account_verified_email" in request.session
email_address = request.session.get("account_verified_email")
assert "account_verified_email" in request.session
email_address = request.session["account_verified_email"]

If you assert it, no need to break the yping then.


if email_address:
Expand Down
Loading