Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): bump joi and express-joi-validation #2135

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

halfwhole
Copy link
Collaborator

Problem

With npm v8 install, the --legacy-peer-deps flag is necessary because of conflicting peer dependencies, and we'd like to get rid of this flag by resolving the peer dependency conflicts.

One of these conflicts is between express-joi-validation and @hapi/joi. express-joi-validation is at 4.0.3 which wants @hapi/joi at 16 as a peer dependency, but @hapi/joi is currently 17 which is incompatible.

Solution

Upgrade express-joi-validation to the latest which is 5.0.1, and upgrade @hapi/joi from 17.1.1 to the latest joi at 17.7.0 (@hapi/joi has been deprecated in favour of joi). These latest versions of express-joi-validation and joi are compatible as peer dependencies.

(There are other remaining peer deps conflicts to resolve, so we can't get rid of --legacy-peer-deps just yet.)

Tests

  • Tested on staging, all looks fine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant