build(deps): bump joi and express-joi-validation #2135
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
With npm v8 install, the
--legacy-peer-deps
flag is necessary because of conflicting peer dependencies, and we'd like to get rid of this flag by resolving the peer dependency conflicts.One of these conflicts is between
express-joi-validation
and@hapi/joi
.express-joi-validation
is at 4.0.3 which wants@hapi/joi
at 16 as a peer dependency, but@hapi/joi
is currently 17 which is incompatible.Solution
Upgrade
express-joi-validation
to the latest which is 5.0.1, and upgrade@hapi/joi
from 17.1.1 to the latestjoi
at 17.7.0 (@hapi/joi
has been deprecated in favour ofjoi
). These latest versions ofexpress-joi-validation
andjoi
are compatible as peer dependencies.(There are other remaining peer deps conflicts to resolve, so we can't get rid of
--legacy-peer-deps
just yet.)Tests