[energidataservice] Add support for variable spot price resolution #18379
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlaur
changed the title
jlaur
force-pushed
the
energidataservice-duration
branch
from
44a4e38 to
e3699e9
Compare
Contributor
There was a problem hiding this comment.
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (1)
bundles/org.openhab.binding.energidataservice/src/main/java/org/openhab/binding/energidataservice/internal/provider/cache/SpotPriceSubscriptionCache.java:86
- Verify that subtracting the price duration from midnight correctly defines the caching boundary for both hourly and 15-minute resolutions, ensuring that edge cases are handled as intended.
Instant end = ZonedDateTime.of(date.plusDays(1), LocalTime.MIDNIGHT, NORD_POOL_TIMEZONE).minus(priceDuration).toInstant();
...penhab/binding/energidataservice/internal/provider/cache/SpotPriceSubscriptionCacheTest.java
Show resolved
Hide resolved
Signed-off-by: Jacob Laursen <[email protected]>
jlaur
force-pushed
the
energidataservice-duration
branch
from
e3699e9 to
b3ed4c4
Compare
jlaur
added a commit
to jlaur/openhab-addons
that referenced
this pull request
Jun 30, 2025
Signed-off-by: Jacob Laursen <[email protected]>
kaikreuzer
pushed a commit
that referenced
this pull request
Jul 1, 2025
Signed-off-by: Jacob Laursen <[email protected]>
jlaur
added
the
backported
phenix1990
pushed a commit
to phenix1990/openhab-addons
that referenced
this pull request
Jul 31, 2025
Signed-off-by: Jacob Laursen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is some preliminary work in preparation for spot prices in 15-minute resolution.