Skip to content

[zwavejs] Fix humidity unit detection #19003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 24, 2025

Conversation

lsiepel
Copy link
Contributor

@lsiepel lsiepel commented Jul 21, 2025

Fixes: #18998
Consists of 2 steps.

  1. Prevent an invalid declared unit to throw IllegalArgumentException and take down the whole thing.
  2. Correct the unit %rH to %

JAR for 5.0.0 M2 or later: https://1drv.ms/u/c/70ea7ac46bc61c73/EYtEveV8x4lGsA_n-Y30vYcB673NLEwjPx529q-H3f57ng?e=4ktm2s

To the reviewer, please backport to 5.0.0.

Signed-off-by: Leo Siepel <[email protected]>
@lsiepel lsiepel added the bug An unexpected problem or unintended behavior of an add-on label Jul 21, 2025
@lsiepel lsiepel requested a review from Copilot July 21, 2025 17:43
Copilot

This comment was marked as resolved.

Signed-off-by: Leo Siepel <[email protected]>
@lsiepel lsiepel requested a review from a team July 21, 2025 17:49
@miloit
Copy link
Contributor

miloit commented Jul 21, 2025

Thank you for fixing

yes, it's running now

…binding/zwavejs/internal/conversion/BaseMetadata.java

Co-authored-by: Copilot <[email protected]>
Signed-off-by: lsiepel <[email protected]>
@lolodomo lolodomo merged commit 9189ca5 into openhab:main Jul 24, 2025
2 checks passed
@lolodomo lolodomo added this to the 5.1 milestone Jul 24, 2025
@lsiepel lsiepel deleted the zwavejs-humidity-unit branch July 24, 2025 09:33
@lsiepel
Copy link
Contributor Author

lsiepel commented Jul 24, 2025

@lolodomo no backport?

@lolodomo
Copy link
Contributor

Ok to backport it.
Can you do it ?

lsiepel added a commit that referenced this pull request Jul 24, 2025
* Fix humidity unit
* Improve check

Signed-off-by: Leo Siepel <[email protected]>
Signed-off-by: lsiepel <[email protected]>
@lsiepel lsiepel added the patch A PR that has been cherry-picked to a patch release branch label Jul 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An unexpected problem or unintended behavior of an add-on patch A PR that has been cherry-picked to a patch release branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[zwavejs] Node Unit symbol %rH causes IllegalArgumentException during channel type generation
3 participants