Skip to content

Fix markdown bindings K-L #19018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 16 commits into from
Jul 26, 2025
Merged

Fix markdown bindings K-L #19018

merged 16 commits into from
Jul 26, 2025

Conversation

lsiepel
Copy link
Contributor

@lsiepel lsiepel commented Jul 22, 2025

Ref: #19011

lsiepel added 3 commits July 22, 2025 21:58
@lsiepel
Fix K-L
c03e3a1 
Signed-off-by: Leo Siepel <[email protected]>
@lsiepel
Fix K-L
4ae683b 
Signed-off-by: Leo Siepel <[email protected]>

Signed-off-by: Leo Siepel <[email protected]>

Merge branch 'fix/markdown-issues-k-l' of https://github.com/lsiepel/openhab-addons into fix/markdown-issues-k-l

Signed-off-by: Leo Siepel <[email protected]>

Fix K-L

Signed-off-by: Leo Siepel <[email protected]>
@lsiepel
Merge branch 'fix/markdown-issues-k-l' of https://github.com/lsiepel/…
191934f 
…openhab-addons into fix/markdown-issues-k-l

Signed-off-by: Leo Siepel <[email protected]>
@lsiepel lsiepel mentioned this pull request Jul 22, 2025
Open
14 tasks
@dag81
Copy link
Contributor

dag81 commented Jul 22, 2025 •
edited
Loading

Linktap looks good - Thank you :)

holgerfriedrich
holgerfriedrich approved these changes Jul 22, 2025
View reviewed changes
Copy link
Member

@holgerfriedrich holgerfriedrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer the handling of intentionally empty table rows we had before in KNX docs (i.e. using spaces to have the column markers at the same place, compared to removing the spaces).
But I have no strong feelings here.
-> Approved for knx.

mlobstein
mlobstein reviewed Jul 23, 2025
View reviewed changes
mlobstein
mlobstein requested changes Jul 23, 2025
View reviewed changes
Copy link
Contributor

@mlobstein mlobstein left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for kaleidescape.
comment left for lgtvserial

@lsiepel
REview comments lgtvserial
b35d9f2 
Signed-off-by: Leo Siepel <[email protected]>
@lsiepel lsiepel requested a review from mlobstein July 23, 2025 08:04
mlobstein
mlobstein approved these changes Jul 23, 2025
View reviewed changes
Copy link
Contributor

@mlobstein mlobstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for lgtvserial

mlobstein
mlobstein requested changes Jul 23, 2025
View reviewed changes
@lsiepel
Fix kaleidescape
d9e3692 
Signed-off-by: Leo Siepel <[email protected]>
@lsiepel lsiepel requested a review from mlobstein July 23, 2025 18:19
mlobstein
mlobstein requested changes Jul 23, 2025
View reviewed changes
@lsiepel
Fix Kaleidescape
42f6f72 
Signed-off-by: Leo Siepel <[email protected]>
@lsiepel lsiepel requested a review from mlobstein July 23, 2025 20:38
lsiepel
lsiepel commented Jul 23, 2025
View reviewed changes
mlobstein
mlobstein approved these changes Jul 24, 2025
View reviewed changes
Copy link
Contributor

@mlobstein mlobstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for kaleidescape

wborn
wborn reviewed Jul 26, 2025
View reviewed changes
lsiepel and others added 3 commits July 26, 2025 10:50
@wborn wborn requested a review from Copilot July 26, 2025 09:21
Copilot
Copilot AI reviewed Jul 26, 2025
View reviewed changes
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request fixes markdown syntax issues in documentation files for bindings with names starting with K and L, addressing formatting and display problems in README files and related documentation.

  • Fixed markdown table formatting by removing malformed table separators and adding proper column separators
  • Corrected markdown syntax for headers, links, and list formatting
  • Fixed spelling errors and improved clarity in documentation text

Reviewed Changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
bundles/org.openhab.binding.luxtronikheatpump/README.md Added missing blank line before markdown table
bundles/org.openhab.binding.lutron/doc/leapnotes.md Updated GitHub reference and added missing blank line before code block
bundles/org.openhab.binding.lutron/README.md Fixed markdown headers and improved section structure
bundles/org.openhab.binding.linky/doc/myelectricaldata/index.md Restructured numbered list formatting and added proper title
bundles/org.openhab.binding.linky/doc/enedis/index.md Restructured numbered list formatting and added proper title
bundles/org.openhab.binding.linky/README.md Fixed markdown formatting, improved links, and corrected spelling errors
bundles/org.openhab.binding.linktap/README.md Fixed header formatting and removed trailing newline
bundles/org.openhab.binding.lgtvserial/README.md Fixed markdown escaping for asterisks and table formatting
bundles/org.openhab.binding.lgthinq/README.md Fixed table formatting and improved section headers
bundles/org.openhab.binding.leapmotion/README.md Fixed table formatting and improved description readability
bundles/org.openhab.binding.knx/README.md Fixed emphasis formatting and table separators
bundles/org.openhab.binding.kaleidescape/README.md Fixed table formatting and corrected spelling error

lsiepel and others added 5 commits July 26, 2025 11:22
@wborn wborn merged commit 834b587 into openhab:main Jul 26, 2025
2 checks passed
@wborn wborn added this to the 5.1 milestone Jul 26, 2025
@lsiepel lsiepel deleted the fix/markdown-issues-k-l branch July 26, 2025 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@holgerfriedrich holgerfriedrich holgerfriedrich approved these changes

@wborn wborn wborn approved these changes

@dag81 dag81 dag81 approved these changes

@mlobstein mlobstein mlobstein approved these changes

@sgiehl sgiehl Awaiting requested review from sgiehl sgiehl is a code owner

@bobadair bobadair Awaiting requested review from bobadair bobadair is a code owner

@clinique clinique Awaiting requested review from clinique clinique is a code owner

@lolodomo lolodomo Awaiting requested review from lolodomo lolodomo is a code owner

@fa2k fa2k Awaiting requested review from fa2k fa2k is a code owner

@kaikreuzer kaikreuzer Awaiting requested review from kaikreuzer kaikreuzer is a code owner

Assignees
No one assigned
Labels
documentation
Projects
None yet
Milestone
5.1
Development

Successfully merging this pull request may close these issues.
5 participants
@lsiepel @dag81 @holgerfriedrich @wborn @mlobstein