Skip to content

[electroluxappliance] Readme.md corrections and JWT handling #19021

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

dag81
Copy link
Contributor

@dag81 dag81 commented Jul 22, 2025

This PR fixes typos in the README.md and implements JWT token handling improvements for the Electrolux appliance binding.

The changes correct documentation errors and add persistent storage for refresh tokens to improve authentication reliability.

  • Corrects spelling errors in README.md including "serialNumber" typos and icon case standardization
  • Adds JWT token storage functionality to persist refresh tokens across restarts
  • Fixes incorrect category assignment for a "Powered On" channel from "Temperature" to "Switch"

(Thank you co-pilot for the summary :) )

[electroluxappliance] Readme.md corrections

Signed-off-by: David Goodyear <[email protected]>
@dag81 dag81 requested a review from jannegpriv as a code owner July 22, 2025 21:40
@dag81 dag81 requested a review from lsiepel July 22, 2025 21:40
@dag81 dag81 marked this pull request as draft July 22, 2025 22:40
@dag81
Copy link
Contributor Author

dag81 commented Jul 22, 2025

Converting to draft as there will be more additions there appears to be issues with the JWT handling going on, when using the OpenJDK on our Linux server.

[electroluxappliance] JWT Persistence

Signed-off-by: David Goodyear <[email protected]>
@dag81
Copy link
Contributor Author

dag81 commented Jul 22, 2025

Soak testing now version 5 is on our server. I suspect the JWT refresh invalidates the old one. As my systems are file configured for easy restoration, when I updated the configs, I believe it reloaded the definitions including the original JWT. Therefore the additional changes add the JWT to be persisted so that if there is a double initialisation or a re-initialisation it is restored e.g. when file config's are done. I'll run this for a while and try a few file re-configs tomorrow, before marking the PR as non draft to make sure it continues running as it should, once I've confirmed no more JWT errors appear and loose comm's.

@dag81 dag81 changed the title [electroluxappliance] Readme.md corrections [electroluxappliance] Readme.md corrections and JWT handling Jul 22, 2025
@dag81 dag81 added the bug An unexpected problem or unintended behavior of an add-on label Jul 22, 2025
[electroluxappliance] Power-on category correction

Signed-off-by: David Goodyear <[email protected]>
@dag81
Copy link
Contributor Author

dag81 commented Jul 24, 2025

The changes work as expected when updating config files with the persisted token no more JWT errors happen, that require getting a new token.
The Category change was tested, the channels update with the new icon, and users can update their items if required, to the new definition.

@dag81 dag81 marked this pull request as ready for review July 24, 2025 21:07
@wborn wborn requested a review from Copilot July 26, 2025 14:40
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes typos in the README.md and implements JWT token handling improvements for the Electrolux appliance binding. The changes correct documentation errors and add persistent storage for refresh tokens to improve authentication reliability.

  • Corrects spelling errors in README.md including "serialNumber" typos and icon case standardization
  • Adds JWT token storage functionality to persist refresh tokens across restarts
  • Fixes incorrect category assignment for a "Powered On" channel from "Temperature" to "Switch"

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File Description
README.md Fixes typos in parameter names and standardizes icon case formatting
thing-types.xml Corrects category for "Powered On" channel from Temperature to Switch
ElectroluxApplianceHandlerFactory.java Moves storage initialization to be shared across all handlers
ElectroluxApplianceBridgeHandler.java Adds JWT token persistence using storage service

[electroluxappliance] Constants for storage keys

Signed-off-by: David Goodyear <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An unexpected problem or unintended behavior of an add-on documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants