Skip to content

Fix markdown bindings T-V #19028

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Jul 26, 2025
Merged

Fix markdown bindings T-V #19028

merged 11 commits into from
Jul 26, 2025

Conversation

lsiepel
Copy link
Contributor

@lsiepel lsiepel commented Jul 23, 2025

Ref: #19011

Signed-off-by: Leo Siepel <[email protected]>
Copy link
Contributor

@andrewfg andrewfg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Velux

Copy link
Contributor

@mlobstein mlobstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for tivo

Signed-off-by: Leo Siepel <[email protected]>
Copy link
Contributor

@psmedley psmedley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved for Teslascope

Signed-off-by: Leo Siepel <[email protected]>
@lsiepel lsiepel requested a review from clinique as a code owner July 24, 2025 09:27
Copy link
Contributor

@dag81 dag81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Vesync LGTM thank you!

@wborn wborn requested a review from Copilot July 26, 2025 09:45
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes various markdown formatting issues across multiple binding README files as part of a broader cleanup effort for bindings with names from T-V. The changes focus on correcting table formatting, fixing spelling errors, improving list formatting, and standardizing documentation structure.

Key changes include:

  • Fixing table formatting with missing pipes and proper alignment
  • Correcting spelling errors (e.g., "suported" → "supported", "informations" → "information")
  • Standardizing list bullet points from mixed +/* to consistent - formatting
  • Adding missing headers and improving document structure

Reviewed Changes

Copilot reviewed 20 out of 22 changed files in this pull request and generated no comments.

Show a summary per file
File Description
bundles/org.openhab.binding.vitotronic/README.md Fixed missing pipe in table row
bundles/org.openhab.binding.visualcrossing/README.md Fixed URL formatting and corrected spelling
bundles/org.openhab.binding.vigicrues/README.md Fixed spelling error in channel description
bundles/org.openhab.binding.vesync/README.md Removed extra blank line
bundles/org.openhab.binding.verisure/README.md Fixed email formatting and added missing table separator
bundles/org.openhab.binding.velux/doc/*.md Added proper headers to example files
bundles/org.openhab.binding.velux/README.md Fixed spelling errors
bundles/org.openhab.binding.velbus/README.md Standardized list formatting and improved table structure
bundles/org.openhab.binding.tuya/README.md Converted bullet points from + to - format
bundles/org.openhab.binding.tr064/README.md Fixed spelling and formatting issues
bundles/org.openhab.binding.touchwand/README.md Fixed table formatting with missing pipes
bundles/org.openhab.binding.tibber/README.md Improved section headers and code block formatting
bundles/org.openhab.binding.teslascope/README.md Fixed spelling errors and added missing table separators
bundles/org.openhab.binding.teslapowerwall/README.md Removed extra blank line
bundles/org.openhab.binding.tellstick/README.md Added alt text to images and fixed spelling
bundles/org.openhab.binding.tapocontrol/README.md Fixed spelling errors
bundles/org.openhab.binding.tacmi/README.md Fixed table formatting issue

@@ -25,7 +25,7 @@ The following Tapo-Devices are supported. For precise channel-description look a
| Smart Temperature Sensor (RF) | T310 | Temperature and Humidity Sensor |
| | T315 | Temperature and Humidity Sensor with Display |
| Smart Switch (RF) | S210 | Wall switch with 1 contact |
| Smart Switch (RF) | S220 | Wall switch with 2 contacts |
| Smart Switch (RF) | S220 | Wall switch with 2 contacts |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| Smart Switch (RF) | S220 | Wall switch with 2 contacts |
| Smart Switch (RF) | S220 | Wall switch with 2 contacts |

(it's the line above that has wrong indentation)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can’t fix this on my phone without creating new issues. I’ll probably create a follow up PR that will fix all table markup. (And adds a ci check ) please merge this as is, rendered layout should not have been negatively impacted.

@wborn wborn mentioned this pull request Jul 26, 2025
@wborn wborn merged commit 45709e0 into openhab:main Jul 26, 2025
1 of 2 checks passed
@wborn wborn added this to the 5.1 milestone Jul 26, 2025
@lsiepel lsiepel deleted the fix/markdown-issues-t-v branch July 26, 2025 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants