[zwavejs] Fix Channel configuration overwrite #19036
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Leo Siepel <[email protected]>
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug in the Z-Wave JS binding where channel configurations were being overwritten during Thing re-initialization. The issue occurred when users changed channel configurations, but the Thing's re-initialization process would recreate all channels with default settings, discarding the user's customizations.
Key changes:
- Refactored the
updateChannelsmethod to perform delta operations instead of recreating all channels - Added logic to preserve existing channels and only add/remove channels as needed
- Improved documentation with detailed JavaDoc comments
...g.zwavejs/src/main/java/org/openhab/binding/zwavejs/internal/handler/ZwaveJSNodeHandler.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Leo Siepel <[email protected]>
lsiepel
added a commit
that referenced
this pull request
Jul 25, 2025
* Rewrite updateChannels Signed-off-by: Leo Siepel <[email protected]>
lsiepel
added
the
patch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just before the release of this binding as part of openHAB 5, a bug was fixed that inadvertently revealed another, older one.
During Thing initialization, all channels were being re-created. Initially, this was fine, but when changing the configuration, the Thing would re-initialize and all channels—using their default configuration—would be re-created again, overwriting any configuration changes.
In short, the updateChannels method was refactored to perform only delta operations and leave existing channels untouched. As a side effect, binding initialization should now be faster, as channels typically do not change that often.
Should be backported to 5.0.x