[somfytahoma] make token refreshing independent on event polling frequency #19038
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
octa22
force-pushed
the
somfytahoma-binding-refresh-fix
branch
from
3e1da8d to
2a8cbbe
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR fixes token refresh timing issues in the SomfyTahoma binding by decoupling token refresh from event polling frequency. The token refresh now uses its own scheduled future that triggers 30 seconds before token expiration, making it independent of the event polling configuration.
- Introduces a dedicated scheduled future for token refresh operations
- Removes token expiration checking from the event polling loop
- Updates configuration constraints to ensure event polling is more frequent than device status reconciliation
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| config.xml | Updates parameter constraints and descriptions for refresh and statusTimeout |
| SomfyTahomaBridgeHandler.java | Implements independent token refresh scheduling and removes token checking from event polling |
...src/main/java/org/openhab/binding/somfytahoma/internal/handler/SomfyTahomaBridgeHandler.java
Outdated
Show resolved
Hide resolved
bundles/org.openhab.binding.somfytahoma/src/main/resources/OH-INF/config/config.xml
Show resolved
Hide resolved
octa22
force-pushed
the
somfytahoma-binding-refresh-fix
branch
2 times, most recently
from
ceeab00 to
ffc5879
Compare
lolodomo
requested changes
Jul 26, 2025
| <default>300</default> | ||
| </parameter> | ||
|
|
||
| <parameter name="retries" type="integer" required="false"> | ||
| <label>Retries</label> | ||
| <description>Specifies the number of retries when command execution</description> | ||
| <description>Specifies how many times the command should be retried upon failure</description> |
There was a problem hiding this comment.
As you adjusted 2 parameter descriptions, please update accordingly the properties file.
…uency Signed-off-by: Ondrej Pecta <[email protected]>
octa22
force-pushed
the
somfytahoma-binding-refresh-fix
branch
from
ffc5879 to
ffe5cc1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes bug and possible misconfiguation mentioned here #18987
Now the token refresh has its own scheduled future and is independent on frequency of event polling from the cloud.