[ephemeris] Evolutions of the Ephemeris module #1169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gaël L'hopital <[email protected]>
|
This pull request has been mentioned on openHAB Community. There might be relevant details there: |
Signed-off-by: Gaël L'hopital <[email protected]>
cweitkamp
reviewed
Oct 29, 2019
.../org.openhab.core.model.script/src/org/eclipse/smarthome/model/script/actions/Ephemeris.java
Outdated
Show resolved
Hide resolved
...ts/src/main/java/org/eclipse/smarthome/core/ephemeris/internal/EphemerisManagerImplTest.java
Outdated
Show resolved
Hide resolved
...main/java/org/openhab/core/automation/internal/module/handler/EphemerisConditionHandler.java
Outdated
Show resolved
Hide resolved
...nhab.core.ephemeris/src/main/java/org/eclipse/smarthome/core/ephemeris/EphemerisManager.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Gaël L'hopital <[email protected]>
Signed-off-by: Gaël L'hopital <[email protected]>
cweitkamp
reviewed
Oct 31, 2019
...rc/main/java/org/eclipse/smarthome/core/ephemeris/internal/EphemerisManagerImplOSGiTest.java
Show resolved
Hide resolved
Signed-off-by: Gaël L'hopital <[email protected]>
cweitkamp
approved these changes
Nov 4, 2019
wborn
added a commit
to wborn/openhab-core
that referenced
this pull request
Nov 8, 2019
Jollyday requires JAXB 2.3 on Java 11 whereas only 2.2 is available during compilation for Java 8 compatibility. See also: * https://github.com/openhab/openhab2-addons/issues/6334 * openhab#1170 * openhab#1169 Signed-off-by: Wouter Born <[email protected]>
kaikreuzer
pushed a commit
that referenced
this pull request
Nov 8, 2019
Jollyday requires JAXB 2.3 on Java 11 whereas only 2.2 is available during compilation for Java 8 compatibility. See also: * https://github.com/openhab/openhab2-addons/issues/6334 * #1170 * #1169 Signed-off-by: Wouter Born <[email protected]>
cweitkamp
changed the title
splatch
pushed a commit
to ConnectorIO/copybara-hab-core
that referenced
this pull request
Jul 11, 2023
* Evolutions of the Ephemeris module Signed-off-by: Gaël L'hopital <[email protected]> GitOrigin-RevId: 4fef010
splatch
pushed a commit
to ConnectorIO/copybara-hab-core
that referenced
this pull request
Jul 11, 2023
Jollyday requires JAXB 2.3 on Java 11 whereas only 2.2 is available during compilation for Java 8 compatibility. See also: * https://github.com/openhab/openhab2-addons/issues/6334 * openhab#1170 * openhab#1169 Signed-off-by: Wouter Born <[email protected]> GitOrigin-RevId: d627a6b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a follow-up of this discussion
Added unit tests over Ephemeris
Ephemeris retrieves by default the Holiday key
Added a function to get localized name of a given holiday key
Added ability to get the number of days until a holiday
Added ability to get next first holiday
Adapted and extended scripting capability accordingly
Signed-off-by: Gaël L'hopital [email protected]