Skip to content

[automation] Extend provider script extension for metadata & ItemChannelLinks #4865

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Jun 29, 2025
Merged

[automation] Extend provider script extension for metadata & ItemChannelLinks #4865

merged 12 commits into from
Jun 29, 2025
+823 −163

Conversation

florian-h05
Copy link
Contributor

@florian-h05 florian-h05 commented Jun 22, 2025 •
edited
Loading

Follow-up for #4513.

This moves the newly added provider script extension to a new package and etxends it with support for providing item metadata & ItemChannelLinks.

@florian-h05 florian-h05 force-pushed the provider branch 2 times, most recently from f5490b4 to ad3d93a Compare June 22, 2025 21:00
@florian-h05 florian-h05 marked this pull request as ready for review June 22, 2025 21:02
@florian-h05 florian-h05 requested a review from a team as a code owner June 22, 2025 21:02
@florian-h05 florian-h05 changed the title [automation] Extend provider script extension for Metadata & ItemChannelLink [automation] Extend provider script extension for metadata & ItemChannelLinks Jun 22, 2025
@florian-h05 florian-h05 reopened this Jun 22, 2025
@florian-h05
Copy link
Contributor Author

@kaikreuzer Can you please have a look at this?
It is a follow-up for #4513 and should be merged before the 5.0 release as it moves classes around, which would be breaking if the status quo makes it into a release.

kaikreuzer
kaikreuzer requested changes Jun 28, 2025
View reviewed changes
Copy link
Member

@kaikreuzer kaikreuzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You will need to add the new bundle to the BOM at https://github.com/openhab/openhab-core/blob/main/bom/openhab-core/pom.xml.
Additionally, you need to add the bundle to the automation script feature (https://github.com/openhab/openhab-core/blob/main/features/karaf/openhab-core/src/main/feature/feature.xml#L140-L143) or create a new feature (similar to the rulesupport one) and add it to the openhab-runtime-base feature.

@florian-h05
Copy link
Contributor Author

Done ✔️

@kaikreuzer
Copy link
Member

Lgtm, but why is the build failing?

florian-h05 added 11 commits June 28, 2025 23:16
@florian-h05
[automation] Move provider script extension to a new bundle
1a00571 
Signed-off-by: Florian Hotze <[email protected]>
@florian-h05
[automation] Add ProviderRegistryDelegate interface and improve Provi…
75d06f7 
…derScriptExtension code

Signed-off-by: Florian Hotze <[email protected]>
@florian-h05
[automation] Add ScriptedMetadataProvider & ProviderMetadataRegistryD…
688e4ea 
…elegate

Signed-off-by: Florian Hotze <[email protected]>
@florian-h05
Fix build
019fed4 
Signed-off-by: Florian Hotze <[email protected]>
@florian-h05
Rename ProviderRegistryDelegate.java to ProviderRegistry.java
f1b8b59 
Signed-off-by: Florian Hotze <[email protected]>
@florian-h05
[automation] Add ScriptedItemChannelLinkProvider & ProviderItemChanne…
65f1836 
…lLinkRegistry

Signed-off-by: Florian Hotze <[email protected]>
@florian-h05
[automation] Implement ProviderItemChannelLinkRegistry::purge
d7ed975 
Signed-off-by: Florian Hotze <[email protected]>
@florian-h05
Improve code
5105de2 
Signed-off-by: Florian Hotze <[email protected]>
@florian-h05
Fixes
882a2b4 
Signed-off-by: Florian Hotze <[email protected]>
@florian-h05
Add new bundle to BOM
5094586 
Signed-off-by: Florian Hotze <[email protected]>
@florian-h05
Add Karaf feature for new bundle
393dbe5 
Signed-off-by: Florian Hotze <[email protected]>
@florian-h05
Fix build
b86c6c9 
Signed-off-by: Florian Hotze <[email protected]>
@florian-h05
Copy link
Contributor Author

Rebasing and fixing code related to #4827 afterwards solved the build issue.

@florian-h05
Copy link
Contributor Author

I just noticed all core builds are failing since the merges of #4874 and #4827, this fixes this.

kaikreuzer
kaikreuzer approved these changes Jun 29, 2025
View reviewed changes
Copy link
Member

@kaikreuzer kaikreuzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks a lot!

@kaikreuzer kaikreuzer merged commit 80d20d1 into openhab:main Jun 29, 2025
4 checks passed
@kaikreuzer kaikreuzer added this to the 5.0 milestone Jun 29, 2025
@kaikreuzer kaikreuzer added the enhancement An enhancement or new feature of the Core label Jun 29, 2025
@florian-h05 florian-h05 deleted the provider branch June 29, 2025 09:33
@florian-h05
Copy link
Contributor Author

@kaikreuzer Can you please trigger a new core build on Jenkins? The one tonight failed.

@holgerfriedrich
Copy link
Member

@florian-h05 done and build completed

@florian-h05
Copy link
Contributor Author

It seems like the current distro build did not include the latest core build, so can you please trigger distro as well?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaikreuzer kaikreuzer kaikreuzer approved these changes

Assignees
No one assigned
Labels
enhancement An enhancement or new feature of the Core
Projects
None yet
Milestone
5.0
Development

Successfully merging this pull request may close these issues.
3 participants
@florian-h05 @kaikreuzer @holgerfriedrich