Thing and triggerchannel pickers #2129
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dmitry P. (d51x) <[email protected]>
Signed-off-by: Dmitry P. (d51x) <[email protected]>
Signed-off-by: Dmitry P. (d51x) <[email protected]>
Job #1197: Bundle Size — 15.8MiB (+0.25%).Warning Bundle contains 16 duplicate packages – View duplicate packages Warning Bundle introduced 13 new packages: @jsep-plugin/regex, @jsep-plugin/arrow, @jsep-plugin/object and 10 more – View changed packages Bundle metrics
  
Bundle size by type
View job #1197 report View d51x:thing-and-triggerchannel-pi... branch activity |
florian-h05
requested changes
Nov 17, 2023
|
@d51x Still on it? |
No, another system of a smart house conquered my heart))) |
|
Out of interest: Which one? |
|
Superseded by #3126. |
florian-h05
added a commit
that referenced
this pull request
Apr 5, 2025
Closes #2128. Replaces abandonded PR #2129. Displays the Thing location (if any) in the Thing picker and the channel description in the channel picker, which improves UX greatly as it allows to distinguish Things easier and know the channel functionality without having to lookup documentation. Also disables virtual list for the Thing picker to avoid issues with the height due to the different entry heights, as the Things page does not use a virtual list, we should also be fine without here. --------- Also-by: Dmitry P. (d51x) <[email protected]> Signed-off-by: Florian Hotze <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
discussion #2128