Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a WIP PR for the issue #2275
The PR uses these audio WebSocket which is still in review openhab/openhab-core#4032 so you need to use the
org.openhab.core.io.websocket
andorg.openhab.core.voice
bundles from there if you want to test it.It is built on top of the webpack 5 upgrade PR #2267, because on webpack 4 you need to use loaders and I didn't want to generate more work to do in a future upgrade. The actual PR changes are in the last commit.Changes added:
I have added that panel at the end of the "help & about" page (it should only be displayed if the necessary APIs are available), it contains the following options:
Modifying any of the options triggers a page reload.
The dialog will use the voice services configured at "Settings / Voice". Once the dialog is running it can be triggered using the voice if the rustpotter model was provided, or using the listenAndAnswer action. For example from the oh console by running
voice listenandanswer --source pcm::ui-52-68::source --sink pcm::ui-52-68::sink
.For now I have placed some console warning in the events emitted about the dialog state.
I wanted to open the PR in case you can give me some feedback about the integration of the feature or in case someone wants to dig into the implementation.
Best regards.