Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve GitHub Actions #3120

Merged
merged 1 commit into from
Apr 2, 2025
Merged

Improve GitHub Actions #3120

merged 1 commit into from
Apr 2, 2025

Conversation

holgerfriedrich
Copy link
Member

  • upgrade relative-ci/agent-action from 2.1.10 to 2.2.0 relative-ci/agent-action@v2.1.10...v2.2.0
  • pin external action relative-ci/agent-action to specific SHA
  • pin external action relative-ci/agent-upload-artifact-action to specific SHA
  • set global timeout
  • comments

@florian-h05 the upgrade of agent-actionis not really necessary and I cannot evaluate - I can set the pinning to the older version if you want. I just saw the latest release and pinned this one.

* upgrade relative-ci/agent-action from 2.1.10 to 2.2.0
  relative-ci/agent-action@v2.1.10...v2.2.0
* pin external action relative-ci/agent-action to specific SHA
* pin external action relative-ci/agent-upload-artifact-action to specific SHA
* set global timeout
* comments

Signed-off-by: Holger Friedrich <[email protected]>
Copy link

relativeci bot commented Mar 26, 2025

#2955 Bundle Size — 11.08MiB (0%).

fcf8938(current) vs fbdcf55 main#2951(baseline)

Warning

Bundle contains 2 duplicate packages – View duplicate packages

Bundle metrics  no changes
                 Current
#2955
     Baseline
#2951
No change  Initial JS 2MiB 2MiB
No change  Initial CSS 577.45KiB 577.45KiB
No change  Cache Invalidation 18.05% 18.05%
No change  Chunks 226 226
No change  Assets 249 249
No change  Modules 2950 2950
No change  Duplicate Modules 150 150
No change  Duplicate Code 1.72% 1.72%
No change  Packages 98 98
No change  Duplicate Packages 2 2
Bundle size by type  no changes
                 Current
#2955
     Baseline
#2951
No change  JS 9.29MiB 9.29MiB
No change  CSS 867.45KiB 867.45KiB
No change  Fonts 526.1KiB 526.1KiB
No change  Media 295.6KiB 295.6KiB
No change  IMG 140.74KiB 140.74KiB
No change  HTML 1.38KiB 1.38KiB
No change  Other 871B 871B

Bundle analysis reportBranch holgerfriedrich:pr-ghaProject dashboard


Generated by RelativeCIDocumentationReport issue

Copy link
Member

@wborn wborn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@florian-h05 florian-h05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!
FYI I am planning to move to add Maven Wrapper and use this one in CI, it will a allow us to get rid of the setup maven third party action and b allow devs to start developing without the need to install maven.

@florian-h05 florian-h05 merged commit 8423149 into openhab:main Apr 2, 2025
5 checks passed
@florian-h05 florian-h05 added this to the 5.0 milestone Apr 2, 2025
@holgerfriedrich holgerfriedrich deleted the pr-gha branch April 2, 2025 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants