[WIP] Add refresh interval option to photos action in OH WebUI #3332
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR introduces a new configuration option to set the display duration for photos in the Photo Browser component. The duration can now be specified in milliseconds (ms) or seconds (s), giving users more flexibility when displaying images or videos. Changes: Added a new property displayDuration to actionPhotoBrowserConfig. Supports numeric values in milliseconds (e.g., 5000) or string values in seconds (e.g., "5s"). Updated documentation and examples to show usage with both ms and s formats. Signed-off-by: Anpro88 <[email protected]>
- Added `actionPhotosRefreshSec` and `actionPhotosRefreshMs` parameters. - Parameters are only active when action is set to 'photos'. - Allows automatic photo refresh with configurable interval. Signed-off-by: Anpro88 <[email protected]>
Add configurable display duration for photos in Photo Browser
Member
And you are most welcome!
Maybe from a UX perspective you could merge those and have the value be Otherwise, the code looks good! |
Author
|
Thanks a lot for the feedback! 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my first attempt at contributing to the OH WebUI.
The goal is to add an optional refresh interval to the
photosaction so that images in the Framework7 Photo Browser can automatically reload after a defined number of seconds or milliseconds.Changes include:
actionPhotosRefreshSec(seconds) andactionPhotosRefreshMs(milliseconds) configuration parameters.photosaction handling to trigger periodic refreshes when one of these values is set.Status:
Thanks in advance for your patience with my first PR attempt!