Adapt UI's to core sitemap registry implementation #3349
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mherwege
requested review from
kaikreuzer,
lolodomo and
peuter
as code owners
This was referenced Sep 3, 2025
peuter
approved these changes
Sep 4, 2025
Member
peuter
left a comment
peuter
left a comment
There was a problem hiding this comment.
LGTM.
The whole sitemap usage in the cometvisu was always just meant as a jumpstart to convert a sitemap into a cometvisu config file, which the user could then use to refine. It never fully supported all sitemap features because there is no 100% mapping for the conmetvisu UI definitions.
And I just found out that its broken anyways at least since openhab 5.0.
Because no one has ever complained about that problem I assume that no-one uses the sitemap converter.
So long story short: Can be merged but I will remove that whole sitemap implementation as soon as I find the time to do so (definitely for the 5.1.0 release).
Signed-off-by: Mark Herwege <[email protected]>
mherwege
force-pushed
the
sitemap_registry
branch
from
5cd761b to
88c8526
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on openhab/openhab-core#5004
This is required if the core PR would be merged, or BasicUI and CometVisu will not work anymore.
I have tested with BasicUI. I don't use CometVisu but have done similar changes as for BasicUI.