Fix F7Router issues with browser history #3451
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#3703 Bundle Size — 12.29MiB (~+0.01%).85ef892(current) vs e2fc3c3 main#3701(baseline) Warning Bundle contains 2 duplicate packages – View duplicate packages Bundle metrics
|
| Current #3703 |
Baseline #3701 |
|
|---|---|---|
 Initial JS |
1.51MiB(~+0.01%) |
1.51MiB |
 Initial CSS |
0B |
0B |
| Cache Invalidation |
7.06% |
7.06% |
| Chunks |
612 |
612 |
| Assets |
692 |
692 |
| Modules |
2406 |
2406 |
| Duplicate Modules |
0 |
0 |
| Duplicate Code |
0% |
0% |
| Packages |
126 |
126 |
| Duplicate Packages |
1 |
1 |
Bundle size by type 
1 change 1 regression
| Current #3703 |
Baseline #3701 |
|
|---|---|---|
| JS |
10.62MiB (~+0.01%) |
10.62MiB |
| CSS |
843.84KiB |
843.84KiB |
| Fonts |
526.1KiB |
526.1KiB |
| Media |
295.6KiB |
295.6KiB |
| IMG |
45.73KiB |
45.73KiB |
| Other |
847B |
847B |
Bundle analysis report Branch florian-h05:router Project dashboard
Generated by RelativeCI Documentation Report issue
According to https://framework7.io/docs/view#param-browserHistory, either browserHistoryRoot or browserHistorySeparator are required, so that the browser navigation works with F7Router Signed-off-by: Florian Hotze <[email protected]>
Contributor
|
Just curious, does this address many of the router issues we were having? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to https://framework7.io/docs/view#param-browserHistory, either browserHistoryRoot or browserHistorySeparator are required, so that the browser navigation works with F7Router