Skip to content

Conversation

@ccutrer
Copy link
Contributor

@ccutrer ccutrer commented Nov 14, 2025

While this PR isn't strictly dependent on openhab/openhab-core#5131, it won't do anything useful without it.

@relativeci
Copy link

relativeci bot commented Nov 14, 2025

#3731 Bundle Size — 12.29MiB (~+0.01%).

af48d6c(current) vs c2477c5 main#3728(baseline)

Warning

Bundle contains 2 duplicate packages – View duplicate packages

Bundle metrics  Change 1 change Regression 1 regression
                 Current
#3731
     Baseline
#3728
Regression  Initial JS 1.52MiB(~+0.01%) 1.52MiB
No change  Initial CSS 0B 0B
No change  Cache Invalidation 7.06% 7.06%
No change  Chunks 612 612
No change  Assets 692 692
No change  Modules 2406 2406
No change  Duplicate Modules 0 0
No change  Duplicate Code 0% 0%
No change  Packages 126 126
No change  Duplicate Packages 1 1
Bundle size by type  Change 1 change Regression 1 regression
                 Current
#3731
     Baseline
#3728
Regression  JS 10.62MiB (~+0.01%) 10.62MiB
No change  CSS 844.2KiB 844.2KiB
No change  Fonts 526.1KiB 526.1KiB
No change  Media 295.6KiB 295.6KiB
No change  IMG 45.73KiB 45.73KiB
No change  Other 847B 847B

Bundle analysis reportBranch ccutrer:command-sourceProject dashboard


Generated by RelativeCIDocumentationReport issue

@florian-h05
Copy link
Contributor

I’d rather send the command to the JSON endpoint where the source can be transmitted in JSON instead of sending it in a header.
WDYT?

@ccutrer
Copy link
Contributor Author

ccutrer commented Nov 14, 2025

The mobile developers specifically requested that the web UIs put it in a header because that's easiest for them to intercept from their web views and inject their own package ids.

@florian-h05
Copy link
Contributor

Hmm okay. I personally don’t care wrt to Main UI.

@florian-h05 florian-h05 added enhancement New feature or request main ui Main UI labels Nov 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request main ui Main UI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants