Skip to content

Upgrade dependencies, SpotBugs, PMD, CheckStyle #480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 23, 2025

Conversation

holgerfriedrich
Copy link
Member

@holgerfriedrich holgerfriedrich commented Jan 19, 2025

I have put all upgrades in one PR - as separate commits - to ease comparing the results before / after.
Pls. DO NOT SQUASH.

  • Upgrades Checkstyle from 10.17.0 to 10.21.1.
For release notes, see:
https://github.com/checkstyle/checkstyle/releases

Note that default behavior for checking tags in javadoc changed
in version 10.20.2, it will not longer issue a warning about
missing tags if there is no javadoc section at all.
See https://github.com/checkstyle/checkstyle/issues/11584
  • Upgrades PMD from 7.8.0 to 7.9.0
For release notes, see:
https://github.com/pmd/pmd/releases/tag/pmd_releases%2F7.9.0
  • Upgrades spotbugs-maven-plugin from 4.8.6.2 to 4.8.6.6.
For release notes, see:
https://github.com/spotbugs/spotbugs-maven-plugin/releases
  • Upgrade dependencies and plugins
* junit to 5.11.4
* commons-io to 2.18.0
* commons-lang3 to 3.17.0
* maven-plugin-api to 3.9.9
* maven-plugin-annotations 3.15.1
* mojo-executor to 2.4.1
* jsoup to 1.18.3
* jdt-annotations to 2.3.100
* flexmark to 0.64.8
* logback to 1.2.13
* plexus-compiler-eclipse to 2.15.0
* ecj to 3.39.0
* truth to 1.4.4

Notes:

@holgerfriedrich holgerfriedrich requested a review from a team as a code owner January 19, 2025 14:56
Upgrades spotbugs-maven-plugin from 4.8.6.2 to 4.8.6.6.
For release notes, see:
https://github.com/spotbugs/spotbugs-maven-plugin/releases

Signed-off-by: Holger Friedrich <[email protected]>
Upgrades PMD from 7.8.0 to 7.9.0

For release notes, see:
https://github.com/pmd/pmd/releases/tag/pmd_releases%2F7.9.0

Signed-off-by: Holger Friedrich <[email protected]>
Upgrades Checkstyle from 10.17.0 to 10.21.1.

For release notes, see:
https://github.com/checkstyle/checkstyle/releases

Note that default behavior for checking tags in javadoc changed
in version 10.20.2, it will not longer issue a warning about
missing tags if there is no javadoc section at all.
See checkstyle/checkstyle#11584

Signed-off-by: Holger Friedrich <[email protected]>
@holgerfriedrich holgerfriedrich force-pushed the pr-upgrade-all branch 17 times, most recently from 5443a80 to e734c77 Compare January 30, 2025 23:34
* junit to 5.11.4
* commons-io to 2.18.0
* commons-lang3 to 3.17.0
* maven-plugin-api to 3.9.9
* maven-plugin-annotations 3.15.1
* mojo-executor to 2.4.1
* jsoup to 1.18.3
* jdt-annotations to 2.3.100
* flexmark to 0.64.8
* logback to 1.2.13
* ecj to 3.33.0
* truth to 1.4.4

Signed-off-by: Holger Friedrich <[email protected]>
@holgerfriedrich holgerfriedrich changed the title [WIP] Upgrade dependencies, SpotBugs, PMD, CheckStyle Upgrade dependencies, SpotBugs, PMD, CheckStyle Jan 31, 2025
@holgerfriedrich
Copy link
Member Author

The results of my overnight build of add-ons repo with 0.18-SNAPSHOT look similar to the report by Jenkins CI with 0.17. I had 4 more warnings with the new one, bit might be on a slightly different commit.

Copy link
Member

@wborn wborn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for all the upgrades! 👍

@wborn wborn merged commit 238cd26 into openhab:main Feb 23, 2025
2 checks passed
@wborn wborn added this to the 0.18.0 milestone Feb 23, 2025
@holgerfriedrich holgerfriedrich deleted the pr-upgrade-all branch February 23, 2025 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants