Remove PMD rule SimplifyBooleanReturns#481
Merged
kaikreuzer merged 1 commit intoopenhab:mainfrom Jan 26, 2025
Merged
Conversation
Remove from default rule set. Readability of code tends to be better if this rule is not enforced. It can be re-activated on project basis by using a custom ruleset, see configuration parameter pmdRuleset and supply an adapted rule set similar to rules.xml from this repo. Signed-off-by: Holger Friedrich <mail@holger-friedrich.de>
kaikreuzer
approved these changes
Jan 26, 2025
Member
kaikreuzer
left a comment
kaikreuzer
left a comment
There was a problem hiding this comment.
I agree, enforcing this rule decreases readability.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove SimplifyBooleanReturns from default rule set.
Readability of code tends to be better if this rule is not enforced.
It can be re-activated on project basis by using a custom ruleset, see configuration parameter pmdRuleset and supply an adapted rule set similar to rules.xml from this repo.
This is basically my conclusion from openhab/openhab-core#4555 and #4567.
See the code changes proposed in #4555 to get an impression of the readability of code compliant to this rule.