Change Cryptographic Holder Binding to Cryptographic Key Binding #457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sakurann
requested review from
danielfett,
peppelinux,
c2bo,
tplooker,
paulbastian,
awoie and
bc-pi
c2bo
approved these changes
Feb 5, 2025
bc-pi
approved these changes
Feb 13, 2025
jogu
approved these changes
Feb 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #26
The issue described changing Holder Binding to Key Binding, but I don't believe that is correct as there are other ways to bind a credential to a Holder than to use key binding. I therefore updated Cryptographic Holder Binding to Cryptographic Key Binding, which might have been the intent anyway I presume.