move proof types to Annex F #489
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tplooker
reviewed
May 8, 2025
|
|
||
| 1. Provide proof of control alongside key material. | ||
| 1. Provide only proof of control without the key material. | ||
| For Cryptographic Key Binding, the Client has different options to provide Cryptographic Key Binding material for a requested Credential within a proof of a certain proof type. A proof type may provide the cryptographic public key(s) either with corresponding proof(s) of possession or with key attestations. Proof types are defined in (#proof-types). |
There was a problem hiding this comment.
Suggested change
| For Cryptographic Key Binding, the Client has different options to provide Cryptographic Key Binding material for a requested Credential within a proof of a certain proof type. A proof type may provide the cryptographic public key(s) either with corresponding proof(s) of possession or with key attestations. Proof types are defined in (#proof-types). | |
| For Cryptographic Key Binding, the Client has different options to provide Cryptographic Key Binding material for a requested Credential within a proof of a certain proof type. A proof type may provide the cryptographic public key(s) either with corresponding proof(s) of possession of the private key or attestation. Proof types are defined in (#proof-types). |
There was a problem hiding this comment.
"...or with key attestation" would be clearer to me
There was a problem hiding this comment.
Don't feel too strongly, happy with the original text, "proof of possession" alone is probably good enough without my addition.
tplooker
approved these changes
May 8, 2025
|
This should wait until #495 is merged |
tlodderstedt
approved these changes
May 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #304
supersedes #458 (which had some merge conflicts as PR is already 3 months old)
I fixed some text in Section 8.1, moved the annex from C to F and added a short intro text.