Editorial changes to multiple/batch credential issuance section #511
Conversation
| To issue multiple Verifiable Credentials with differing Credential Formats or Credential Datasets, multiple requests MUST be sent to the Credential Endpoint. | ||
|
|
||
| In the course of the authorization process, the Credential Issuer MAY also request Credential presentation as a means to authenticate or identify the End-User during the issuance flow, as described in (#use-case-5). |
There was a problem hiding this comment.
There was a problem hiding this comment.
I agree it seems to be placed in the wrong section. Can we move it somewhere more sensible than deleting it or is it already mentioned elsewhere?
There was a problem hiding this comment.
@paulbastian @Sakurann i moved the section to the introduction to authorization code flow.
There was a problem hiding this comment.
I'm happy with this change.
moved introduction to credential presentation authentication into the authorization code flow section
|
@jogu I feel that your comments are coming from the perspective that batches means 2 or more, whereas the way i wrote this is that the batches can be 1 or more. I prefer to describe the credential endpoint issuing batches of 1 or more, because the response properties are the same in all cases. However I see that the existing references to batch are written as if batch is 2 or more, and therefore these inconsistencies should be fixed in this PR. I would be interested in more opinions before continuing |
Good point. I asked some of the other editors and everyone seemed happy if we use a definition of "batch" that means "1 or more" so I'll withdraw one of my suggestions. |
Co-authored-by: Joseph Heenan <[email protected]>
| * `batch_credential_issuance`: OPTIONAL. Object containing information about the Credential Issuer's supports for batch issuance of Credentials on the Credential Endpoint. The presence of this parameter means that the issuer supports more than one key proof in the `proofs` parameter in the Credential Request so can issue more than one Verifiable Credential for the same Credential Dataset in a single request/response. | ||
| * `batch_size`: REQUIRED. Integer value specifying the maximum array size for the `proofs` parameter in a Credential Request. | ||
| * `batch_credential_issuance`: OPTIONAL. Object containing information about the Credential Issuer's support for issuance of multiple Credentials in a batch in the Credential Endpoint. The presence of this parameter means that the issuer supports more than one key proof in the `proofs` parameter in the Credential Request so can issue more than one Verifiable Credential for the same Credential Dataset in a single request/response. | ||
| * `batch_size`: REQUIRED. Integer value specifying the maximum array size for the `proofs` parameter in a Credential Request. It MUST be 2 or greater. |
There was a problem hiding this comment.
I asked some of the other editors and everyone seemed happy if we use a definition of "batch" that means "1 or more" so I'll withdraw one of my suggestions.
if this is true, should this not be 1 or greater?
There was a problem hiding this comment.
I think because of the "The presence of this parameter means that the issuer supports more than one key proof in the proofs parameter" on the parent object, it can only be legal to have batch_size of at least 2.
There was a problem hiding this comment.
@Sakurann logically it should be 2 or more, but practically we could drop the statement as it probably doesnt harm interop
There was a problem hiding this comment.
ok. let's keep it as-is then
Co-authored-by: Tobias Looker <[email protected]>
Made the batch use case language stronger
Co-authored-by: Tobias Looker <[email protected]>
resolves #508