Remove the option to use format from authorization_details in the Authorization Request
#517
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Authorization Request
paulbastian
requested review from
jogu,
tlodderstedt,
c2bo,
awoie,
Sakurann and
bc-pi
|
Just want to reference this comment here so it doesn't get missed #275 (comment) |
Sakurann
reviewed
May 26, 2025
| * `credential_configuration_id`: REQUIRED when `format` parameter is not present. String specifying a unique identifier of the Credential being described in the `credential_configurations_supported` map in the Credential Issuer Metadata as defined in (#credential-issuer-parameters). The referenced object in the `credential_configurations_supported` map conveys the details, such as the format, for issuance of the requested Credential. This specification defines Credential Format specific Issuer Metadata in (#format-profiles). It MUST NOT be present if `format` parameter is present. | ||
| * `format`: REQUIRED when `credential_configuration_id` parameter is not present. String identifying the format of the Credential the Wallet needs. This Credential Format Identifier determines further claims in the authorization details object needed to identify the Credential type in the requested format. This specification defines Credential Format Profiles in (#format-profiles). It MUST NOT be present if `credential_configuration_id` parameter is present. | ||
| * `credential_configuration_id`: REQUIRED. String specifying a unique identifier of the Credential being described in the `credential_configurations_supported` map in the Credential Issuer Metadata as defined in (#credential-issuer-parameters). The referenced object in the `credential_configurations_supported` map conveys the details, such as the format, for issuance of the requested Credential. This specification defines Credential Format specific Issuer Metadata in (#format-profiles). | ||
| * `claims`: OPTIONAL. A non-empty array of claims description objects as defined in (#claims-description-authorization-details). |
There was a problem hiding this comment.
referenced section only defines path and mandatory, while removed sections have defined vct, doctype, etc. are we sure this section completely replaces those removed..?
There was a problem hiding this comment.
All of these are present in the credential_configuration_supported map, so I don't see any need for them. Except for claims, which I moved to the common authorization_details in section 5
There was a problem hiding this comment.
then we should expand The referenced object in the credential_configurations_supported map conveys the details, such as the format, for issuance of the requested Credential. section to reflect that
There was a problem hiding this comment.
I made a suggestion
|
Just referencing if this PR is accepted then #481 will need to be closed. |
tlodderstedt
approved these changes
May 27, 2025
paulbastian
commented
May 27, 2025
| * `credential_configuration_id`: REQUIRED when `format` parameter is not present. String specifying a unique identifier of the Credential being described in the `credential_configurations_supported` map in the Credential Issuer Metadata as defined in (#credential-issuer-parameters). The referenced object in the `credential_configurations_supported` map conveys the details, such as the format, for issuance of the requested Credential. This specification defines Credential Format specific Issuer Metadata in (#format-profiles). It MUST NOT be present if `format` parameter is present. | ||
| * `format`: REQUIRED when `credential_configuration_id` parameter is not present. String identifying the format of the Credential the Wallet needs. This Credential Format Identifier determines further claims in the authorization details object needed to identify the Credential type in the requested format. This specification defines Credential Format Profiles in (#format-profiles). It MUST NOT be present if `credential_configuration_id` parameter is present. | ||
| * `credential_configuration_id`: REQUIRED. String specifying a unique identifier of the Credential being described in the `credential_configurations_supported` map in the Credential Issuer Metadata as defined in (#credential-issuer-parameters). The referenced object in the `credential_configurations_supported` map conveys the details, such as the format, for issuance of the requested Credential. This specification defines Credential Format specific Issuer Metadata in (#format-profiles). | ||
| * `claims`: OPTIONAL. A non-empty array of claims description objects as defined in (#claims-description-authorization-details). |
There was a problem hiding this comment.
I made a suggestion
tplooker
approved these changes
Jun 8, 2025
As to not be silent on this here, it would appear subsequent comments have clarified that the affected use case could reference the credential configuration instead of the offer thus not eliminating any functionality from the specification. |
awoie
approved these changes
Jun 10, 2025
charsleysa
approved these changes
Jun 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #275
Supersedes #481
The Format-specific authorization_details only contain examples now. They could as well be removed, or keep them?