-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify ISO mdoc Handover structure. #419
base: main
Are you sure you want to change the base?
Conversation
Fixes openid#415. Signed-off-by: David Zeuthen <[email protected]>
1716677
to
15b8a1f
Compare
Would it make sense to introduce I would also assume that not all readers of this spec will be that familiar with CBOR and CDDL - an explicit reference might help. |
+1 to two things Christian is suggesting (introduce tstr and bstr and references) as it is very true that the audience of this spec cannot be assumed to be cbor experts |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As mentioned, I think this section would benefit from introducing and referencing the CBOR types, but we could also do that in another PR.
I think the proposed changes to clarify the hashing are quite helpful.
* The first element MUST be the fixed UTF-8 encoded string `OpenID4VPDCAPIHandover`. This serves as a unique identifier for the handover structure to prevent misinterpretation or confusion. | ||
* The second element MUST be the `OpenID4VPDCAPIHandoverInfoHash`, represented as a CBOR byte string which encodes the sha-256 hash of the `OpenID4VPDCAPIHandoverInfo` CBOR array. | ||
* The first element MUST be the string `OpenID4VPDCAPIHandover`. This serves as a unique identifier for the handover structure to prevent misinterpretation or confusion. | ||
* The second element MUST be a bytestring which contains the sha-256 hash of the bytes of `OpenID4VPDCAPIHandoverInfo` when encoded as CBOR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* The second element MUST be a bytestring which contains the sha-256 hash of the bytes of `OpenID4VPDCAPIHandoverInfo` when encoded as CBOR. | |
* The second element MUST be a byte string which contains the sha-256 hash of the bytes of `OpenID4VPDCAPIHandoverInfo` when encoded as CBOR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks David! I think further changes are necessary (clarifying effective client id, adding examples) but there are other issues open for that so it would be good to get this merged so the other issues can be worked on.
Fixes #415.