Various editorial nits

[jogu]

No description provided.

[selfissued]

Approved with two suggestions. Thanks for doing this.

[dastoikov]

@jogu: "fullfilled" vs "fulfilled" elsewhere in the document. I believe it was merged yesterday.

[jogu]

@dastoikov

"fullfilled" vs "fulfilled" elsewhere in the document. I believe it was merged yesterday.

I'm not sure if I'm fully following what you meant, but I found and fixed an incorrect "fulfilled" so thank you and hopefully that was what you meant :) (I added you to the acknowledgments too)

If there's something else that still needs fixing please shout!

[dastoikov]

@jogu :

I'm not sure if I'm fully following what you meant, but I found and fixed an incorrect "fulfilled" so thank you and hopefully that was what you meant :)

Yes, I meant the one that you fixed. Apologies for not being clear.

(I added you to the acknowledgments too)

Thank you!

If there's something else that still needs fixing please shout!

I will review the document this evening (UTC+3), so if you are in a hurry, please merge. Most likely, there will not be anything else that needs fixing.

[jogu]

I will review the document this evening (UTC+3), so if you are in a hurry, please merge. Most likely, there will not be anything else that needs fixing.

Thank you! That'd be good, we need to merge it on/before Tuesday, and an extra check & approval would be great!

[dastoikov]

@jogu:

Attached is a patch with some stylistic and language adjustments. Unfortunately, time did not permit a full review.

Notable changes:

1. Replaced “his/her” with “their”, with the primary motivation being alignment with other OpenID specifications (for example, https://openid.net/specs/openid-connect-core-1_0-final.html, where “the user” and “the End-User” are referred to as “they”). Secondary motivation includes that other standards bodies have adopted, at the time of this writing, similar language. For instance: https://www.w3.org/guide/manual-of-style/#inclusive; IETF provides similar guidance.

2. Replaced “ASCII URL safe characters (uppercase and lowercase letters, decimal digits, hyphen, period, underscore, and tilde).” with “US-ASCII characters from the set of URI unreserved characters as defined in Section 2.3 of [@!RFC3986].” for clarity and to avoid placing a normative definition in parentheses.

3. "base64url encoded" is replaced with "base64url-encoded" for uniformity within the document, as the latter form is more frequently used within the document when the notion occurs in the same language context.

I leave it to you to decide what parts of the patch to use.
0001-Some-stylistic-and-language-adjustments.patch.zip

[dastoikov]

@jogu :

Attached is a second patch, this time consisting solely of typo fixes (along with two instances of adding a comma before the last item in a list).

For example, replaced "intend" with "intent" in "issued by a trusted authority, to prove that the Verifier has publicly registered its intent to request certain credentials.".
0001-Typo-fixes.patch.zip

I reviewed the document in full.

[jogu]

Thanks @dastoikov - really great to have someone reading the whole doc! I've applied most of both patches - I didn't take a couple of changes:

• I've retained "interacting with the end-user" rather than simplifying to "interaction" as I think the extra words aid the reader in understanding
• I didn't take the ASCII URL safe change as it felt a little too close to a normative change (I think it's probably okay but I'd rather veer on the side of caution at this late stage - we could definitely put it into a separate PR and consider it for an errata)

[dastoikov]

@jogu: Well, thanks for considering and applying. :)