Consistently use given_name and family_name in examples #663
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sakurann
requested review from
GarethCOliver,
Sakurann,
awoie,
c2bo,
danielfett and
tplooker
Sakurann
approved these changes
Aug 26, 2025
c2bo
requested changes
Aug 26, 2025
There was a problem hiding this comment.
More residues of last_name and first_name:
https://github.com/openid/OpenID4VP/pull/663/files#diff-3118c9756a1d7b361bb53af8bd9d65666476a27cfeeced56c47a5dccc38eac55L459-L460
https://github.com/openid/OpenID4VP/pull/663/files#diff-3118c9756a1d7b361bb53af8bd9d65666476a27cfeeced56c47a5dccc38eac55L1132-L1133
https://github.com/openid/OpenID4VP/pull/663/files#diff-3118c9756a1d7b361bb53af8bd9d65666476a27cfeeced56c47a5dccc38eac55L1340-L1341
Could you change these as well?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #662
I did opt to change all attribute names as I noticed that SD-JWT ones were also not consistent.
Noticed that the main text is also not consistent (but left that as is)