Editorials, defined terms #85
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peppelinux
commented
Dec 14, 2023
tlodderstedt
requested changes
Jan 6, 2024
peppelinux
commented
Jan 6, 2024
Co-authored-by: Torsten Lodderstedt <[email protected]>
peppelinux
commented
Jan 6, 2024
tlodderstedt
requested changes
Jan 30, 2024
Sakurann
reviewed
Mar 23, 2024
Sakurann
reviewed
Mar 23, 2024
Sakurann
reviewed
Mar 23, 2024
peppelinux
commented
May 24, 2024
Sakurann
reviewed
Jan 23, 2025
openid4vc-high-assurance-interoperability-profile-sd-jwt-vc-1_0.md
Outdated
Show resolved
Hide resolved
peppelinux
commented
Feb 6, 2025
openid4vc-high-assurance-interoperability-profile-sd-jwt-vc-1_0.md
Outdated
Show resolved
Hide resolved
peppelinux
changed the title
Sakurann
reviewed
Feb 6, 2025
Co-authored-by: Kristina <[email protected]>
Sakurann
reviewed
Feb 6, 2025
Sakurann
reviewed
Feb 6, 2025
Co-authored-by: Kristina <[email protected]>
selfissued
reviewed
Feb 10, 2025
|
|
||
| SHA256 MUST be supported by all the entities as the hash algorithm to generate and validate the digests in the SD-JWT VC. | ||
| The hash algorithm SHA256 MUST be supported by all the entities to generate and validate the digests in the IETF SD-JWT VC and ISO mdoc. |
There was a problem hiding this comment.
Suggested change
| The hash algorithm SHA256 MUST be supported by all the entities to generate and validate the digests in the IETF SD-JWT VC and ISO mdoc. | |
| The hash algorithm SHA-256 MUST be supported by all the entities to generate and validate the digests in the IETF SD-JWT VC and ISO mdoc. |
selfissued
approved these changes
Feb 10, 2025
c2bo
reviewed
Feb 14, 2025
| @@ -50,7 +50,7 @@ The audience of the document is implementers that require a high level of securi | |||
|
|
|||
| # Terminology | |||
|
|
|||
| This specification uses the terms "Holder", "Issuer", "Verifier", "Wallet", and "Verifiable Credential" as defined in @!OIDF.OID4VCI] and [@!OIDF.OID4VP]. | |||
| This specification uses the terms "Holder", "Issuer", "Verifier", "Wallet", "Wallet Attestation", "Credential Type" and "Verifiable Credential" as defined in @!OIDF.OID4VCI] and [@!OIDF.OID4VP]. | |||
There was a problem hiding this comment.
I think we should split this into terminology defined by specific specs ( termy x,y,z in VCI and a,b,c in VP) similar to how it is done in VCI and VP currently.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR Closes #69