Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OPL-83: Change way settings are loaded #95

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

dborowiecki
Copy link
Contributor

TICKET: OPL-83

@qgerome
Copy link
Contributor

qgerome commented Mar 31, 2022

Please, do not merge that. It's too complex and I can't see what could justify to use such system instead of adding a block of text in the modules' readme explaining what are the settings that need to be added/updated in the settings.py.

You could also use another settings.mycase.py file overriding the default one with your custom configuration using the DJANGO_SETTINGS_MODULE env variable. https://docs.djangoproject.com/en/4.0/topics/settings/#designating-the-settings

IMHO, customising the settings.py is not the responsibility of the modules but the developer/implementer. (and it's a one-time operation)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants