Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Chat supports batch import of JSON and XLSX #338

Merged
merged 15 commits into from
Dec 25, 2023
Merged

feat: Chat supports batch import of JSON and XLSX #338

merged 15 commits into from
Dec 25, 2023

Conversation

withchao
Copy link
Collaborator


🔍 What type of PR is this?

👀 What this PR does / why we need it:

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

🅰 Which issue(s) this PR fixes:

Fixes #337

📝 Special notes for your reviewer:

🎯 Describe how to verify it

📑 Additional documentation e.g., RFC, notion, Google docs, usage docs, etc.:

@withchao withchao requested review from cubxxw and a team as code owners December 22, 2023 09:36
@pull-request-size pull-request-size bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Dec 22, 2023
@sweep-ai Sweep AI
Copy link

sweep-ai bot commented Dec 22, 2023

Apply Sweep Rules to your PR?

  • Apply: All new business logic should have corresponding unit tests.
  • Apply: Refactor large functions to be more modular.
  • Apply: Add docstrings to all functions and file headers.

github-advanced-security[bot]
github-advanced-security bot found potential problems Dec 22, 2023
View reviewed changes
internal/api/admin.go
Nickname: info.Nickname,
FaceURL: info.FaceURL,
Birth: o.xlsxBirth(info.Birth).UnixMilli(),
Gender: int32(gender),

Check failure

Code scanning / CodeQL

Incorrect conversion between integer types High

Incorrect conversion of an integer with architecture-dependent bit size from
strconv.Atoi
Loading
to a lower bit size type int32 without an upper bound check.
pkg/common/xlsx/utils.go
if err != nil {
return err
}
val = uint(t)

Check failure

Code scanning / CodeQL

Incorrect conversion between integer types High

Incorrect conversion of an unsigned 64-bit integer from
strconv.ParseUint
Loading
to a lower bit size type uint without an upper bound check.
@cubxxw cubxxw disabled auto-merge December 25, 2023 02:20
@cubxxw cubxxw added this pull request to the merge queue Dec 25, 2023
Merged via the queue into openimsdk:main with commit 5fb01e1 Dec 25, 2023
9 of 11 checks passed
@openimsdk openimsdk locked and limited conversation to collaborators Dec 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cubxxw cubxxw cubxxw approved these changes

@FGadvancer FGadvancer FGadvancer approved these changes

Assignees
No one assigned
Labels
size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Other]: Chat supports batch import of JSON and XLSX
3 participants
@withchao @FGadvancer @cubxxw