Skip to content

feat: Chat supports batch import of JSON and XLSX#338

Merged
cubxxw merged 15 commits intoopenimsdk:mainfrom
withchao:main
Dec 25, 2023
Merged

feat: Chat supports batch import of JSON and XLSX#338
cubxxw merged 15 commits intoopenimsdk:mainfrom
withchao:main

Conversation

@withchao
Copy link
Contributor

@withchao withchao commented Dec 22, 2023


🔍 What type of PR is this?

👀 What this PR does / why we need it:

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

🅰 Which issue(s) this PR fixes:

Fixes #337

📝 Special notes for your reviewer:

🎯 Describe how to verify it

📑 Additional documentation e.g., RFC, notion, Google docs, usage docs, etc.:

@withchao withchao requested review from a team and cubxxw as code owners December 22, 2023 09:36
@pull-request-size pull-request-size bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Dec 22, 2023
@withchao withchao enabled auto-merge December 22, 2023 09:37
@sweep-ai-deprecated
Copy link

sweep-ai-deprecated bot commented Dec 22, 2023

Apply Sweep Rules to your PR?

  • Apply: All new business logic should have corresponding unit tests.
  • Apply: Refactor large functions to be more modular.
  • Apply: Add docstrings to all functions and file headers.

github-advanced-security[bot]
github-advanced-security bot found potential problems Dec 22, 2023
View reviewed changes
internal/api/admin.go
Nickname: info.Nickname,
FaceURL: info.FaceURL,
Birth: o.xlsxBirth(info.Birth).UnixMilli(),
Gender: int32(gender),

Check failure

Code scanning / CodeQL

Incorrect conversion between integer types

Incorrect conversion of an integer with architecture-dependent bit size from [strconv.Atoi](1) to a lower bit size type int32 without an upper bound check.
pkg/common/xlsx/utils.go
if err != nil {
return err
}
val = uint(t)

Check failure

Code scanning / CodeQL

Incorrect conversion between integer types

Incorrect conversion of an unsigned 64-bit integer from [strconv.ParseUint](1) to a lower bit size type uint without an upper bound check.
@cubxxw cubxxw disabled auto-merge December 25, 2023 02:20
@cubxxw cubxxw added this pull request to the merge queue Dec 25, 2023
Merged via the queue into openimsdk:main with commit 5fb01e1 Dec 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@FGadvancer FGadvancer FGadvancer approved these changes

+1 more reviewer

@cubxxw cubxxw cubxxw approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Other]: Chat supports batch import of JSON and XLSX

3 participants

@withchao @FGadvancer @cubxxw