Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: 3.7.0 code conventions. #2148

Merged
merged 609 commits into from
Apr 19, 2024

Conversation

FGadvancer
Copy link
Member


🔍 What type of PR is this?

👀 What this PR does / why we need it:

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

🅰 Which issue(s) this PR fixes:

Fixes #

📝 Special notes for your reviewer:

🎯 Describe how to verify it

📑 Additional documentation e.g., RFC, notion, Google docs, usage docs, etc.:

Copy link

codecov bot commented Mar 28, 2024

Codecov Report

Attention: Patch coverage is 12.24719% with 781 lines in your changes are missing coverage. Please review.

Project coverage is 5.49%. Comparing base (0b2df42) to head (7969f56).
Report is 45 commits behind head on main.

❗ Current head 7969f56 differs from pull request most recent head 95b19f5. Consider uploading reports for the commit 95b19f5 to get more accurate results

Files Patch % Lines
pkg/common/db/cache/seq.go 0.00% 84 Missing ⚠️
pkg/common/config/config.go 0.00% 71 Missing ⚠️
internal/msggateway/n_ws_server.go 0.00% 58 Missing ⚠️
pkg/common/cmd/root.go 0.00% 47 Missing ⚠️
pkg/common/db/cache/msg.go 47.22% 38 Missing ⚠️
pkg/common/db/cache/third.go 0.00% 33 Missing ⚠️
internal/msggateway/context.go 0.00% 32 Missing ⚠️
pkg/common/webhook/http_client.go 0.00% 30 Missing ⚠️
pkg/common/cmd/msg.go 0.00% 24 Missing ⚠️
pkg/common/cmd/push.go 0.00% 24 Missing ⚠️
... and 33 more
Additional details and impacted files
@@           Coverage Diff            @@
##            main   #2148      +/-   ##
========================================
+ Coverage   4.63%   5.49%   +0.86%     
========================================
  Files         28      64      +36     
  Lines       1814    3695    +1881     
========================================
+ Hits          84     203     +119     
- Misses      1720    3480    +1760     
- Partials      10      12       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@FGadvancer FGadvancer changed the title refactor: 3.6.1 code conventions. refactor: 3.7.0 code conventions. Apr 19, 2024
@skiffer-git skiffer-git merged commit b76816b into openimsdk:main Apr 19, 2024
9 of 23 checks passed
@kubbot kubbot added this to the v3.6 milestone Apr 19, 2024
@openimsdk openimsdk locked and limited conversation to collaborators Apr 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants