Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: merge js sdk #2856

Merged
merged 183 commits into from
Nov 14, 2024
Merged

feat: merge js sdk #2856

merged 183 commits into from
Nov 14, 2024

Conversation

withchao
Copy link
Contributor

🅰 Please add the issue ID after "Fixes #"

Fixes #2855

@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 14, 2024
mo3et
mo3et previously approved these changes Nov 14, 2024
skiffer-git
skiffer-git previously approved these changes Nov 14, 2024
@mo3et mo3et self-requested a review November 14, 2024 04:08
@mo3et
Copy link
Member

mo3et commented Nov 14, 2024

Non-English comments found in the following locations:

./internal/msggateway/encoder_test.go:10:	// 测试用例1: 编码 []byte 数据
./internal/msggateway/encoder_test.go:20:	// 测试用例2: 编码非 []byte 数据
./internal/msggateway/encoder_test.go:31:	// 测试用例1: 解码到 []byte 数据
./internal/msggateway/encoder_test.go:42:	// 测试用例2: 解码到非 []byte 数据

@withchao withchao dismissed stale reviews from skiffer-git and mo3et via b7e6046 November 14, 2024 06:14
mo3et
mo3et previously approved these changes Nov 14, 2024
@mo3et mo3et enabled auto-merge November 14, 2024 06:15
mo3et
mo3et previously approved these changes Nov 14, 2024
@mo3et mo3et added this pull request to the merge queue Nov 14, 2024
Merged via the queue into openimsdk:main with commit 12790e1 Nov 14, 2024
8 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 14, 2024
@FGadvancer FGadvancer added this to the v3.8.2 milestone Nov 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Other]: merge js sdk
4 participants