Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enhance automated review for codeowners #11

Merged
merged 2 commits into from
Jun 24, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
47 changes: 36 additions & 11 deletions docs/CODEOWNERS
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
@@ -1,59 +1,84 @@
# This is a comment.
# Each line is a file pattern followed by one or more owners.

# README files
README.md @cubxxw @kubbot @AllianceTing @IRONICBo @MC-kanon

# Contributing guidelines
CONTRIBUTING.md @kubbot @cubxxw @IRONICBo

# License files
LICENSE @kubbot @cubxxw @IRONICBo

# Makefile
Makefile @kubbot @cubxxw @IRONICBo

# Assets directory
assets/* @AllianceTing @IRONICBo @cubxxw @MC-kanon

# Deploy directory
deploy/* @IRONICBo @cubxxw @kubbot @MC-kanon

# Server directory
server/* @AllianceTing @cubxxw @IRONICBo

# Web directory
web/* @AllianceTing @MC-kanon @IRONICBo

# These owners will be the default owners for everything in
# the repo. Unless a later match takes precedence,
# @cubxxw and @kubbot will be requested for
# review when someone opens a pull request.
* @cubxxw @kubbot
* @cubxxw @kubbot @AllianceTing @IRONICBo @MC-kanon

# Order is important; the last matching pattern takes the most
# precedence. When someone opens a pull request that only
# modifies JS files, only @js-owner and not the global
# owner(s) will be requested for a review.
*.js @cubxxw #This is an inline comment.
*.js @cubxxw @kubbot @IRONICBo @MC-kanon @AllianceTing #This is an inline comment.

# You can also use email addresses if you prefer. They'll be
# used to look up users just like we do for commit author
# emails.
*.go [email protected]
*.go [email protected] @IRONICBo @AllianceTing

# Teams can be specified as code owners as well. Teams should
# be identified in the format @org/team-name. Teams must have
# explicit write access to the repository. In this example,
# the OpenIMSDK team in the github organization owns all .txt files.
*.txt @cubxxw
*.txt @cubxxw @kubbot @AllianceTing @IRONICBo @MC-kanon

# In this example, @cubxxw owns any files in the build/
# directory at the root of the repository and any of its
# subdirectories.
/build/* @cubxxw
build/* @cubxxw @kubbot @IRONICBo @MC-kanon @AllianceTing

# The `docs/*` pattern will match files like
# `docs/getting-started.md` but not further nested files like
# `docs/build-app/troubleshooting.md`.
docs/* [email protected]
docs/* [email protected] @kubbot @IRONICBo

# In this example, @octocat owns any file in an apps directory
# anywhere in your repository.
api/ @cubxxw
api/ @cubxxw @IRONICBo

# In this example, @cubxxw owns any file in the `/docs`
# directory in the root of your repository and any of its
# subdirectories.
/docs/ @cubxxw
/docs/ @cubxxw @kubbot @IRONICBo

# In this example, any change inside the `/scripts` directory
# will require approval from @cubxxw or @octocat.
/scripts/ @cubxxw @kubbot
scripts/* @cubxxw @kubbot @IRONICBo

# In this example, @octocat owns any file in a `/logs` directory such as
# `/build/logs`, `/scripts/logs`, and `/deeply/nested/logs`. Any changes
# in a `/logs` directory will require approval from @octocat.
**/logs @cubxxw
**/logs @cubxxw @kubbot @IRONICBo

# In this example, @octocat owns any file in the `/apps`
# directory in the root of your repository except for the `/apps/github`
# subdirectory, as its owners are left empty.
/apps/ @cubxxw
/apps/github
/apps/ @cubxxw @kubbot @IRONICBo
/apps/github