-
Notifications
You must be signed in to change notification settings - Fork 1
[WIP] [#169] Upgrade Docsy and fix formatting #8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
PROBLEM: The site has been using an older version of Hugo and Docsy. When we tried to add the new Holos page and rendered the site using the newest versions of Hugo/Docsy, lots of formatting and page elements broke. SOLUTION: * Update site configuration to specify the new versions of Docsy/Hugo. * Follow the [site conversion/migration guide](https://www.docsy.dev/docs/updating/convert-site-to-module/) to use Docsy as a Go module. * Convert all image symlinks to native files, as Hugo no longer resolves the symlinks. * Update formatting in the `about` page to use row/column shortcodes. * Specify the `row` type on the main homepage so the feature blocks align as columns. OUTCOME: Executing `hugo serve` locally produces a website with formatting that matches our existing site.
Oh good catch, lemme dig into that tomorrow. There were enough things that DID change that make me suspect we're missing some formatting settings. |
PROBLEM: The columns in the "about" page weren't expanding the width of the page. This is because of a clash between the `row` div in the `blocks/section` shortcode and the `row` shortcode. SOLUTION: Allow the `blocks/section` shortcode to set the `row` div itself, and remove the `row` shortcode. This gives us 100% page width. We also need to set the custom `book` ID to allow text beside the images. OUTCOME: Alignment on the About page matches what we had before.
Hmm, for some reason it's rejecting the Google Font family we're setting in the custom CSS file for JUST the We're doing exactly what the docs say to do: https://www.docsy.dev/docs/adding-content/lookandfeel/#fonts I'm wondering if there's something about |
I hit a timebox on the font problem, here's what I've learned:
$google_font_name: "Roboto";
$google_font_family: "Roboto:300,300i,400,400i,700,700i";
At this point I suspect a bug (either previously that was "fixed", or currently), and/or that we need to write custom CSS to get the title to look the way it was previously. I'm going to work on other things, and come back to this later. I don't think the change in formatting in the title is THAT bad, but I'll leave it up to both of y'all to weigh in on that. |
This commit adds spaces between the main landing page's button text and the arrow icon. This makes the buttons look more like the previous version of Docsy, rather than scrunched together.
I wanted to mention that, as Nate said, there are font differences in other elements on some of the pages. The text in the buttons on the main landing page is a good place to look. I had to add a space between the text and the arrow icon so that they aren't so scrunched together. I'm noticing elements like that which seem to be coming from the version updates. I've had to go back and add attributes to existing elements (like adding |
PROBLEM: Previously some pages were being defined in HTML and some pages were being defined in Markdown. The upstream Hugo/Docsy projects have moved to using Markdown everywhere. SOLUTION: Refactor any pure-HTML pages to Markdown and verify content. OUTCOME: We have standardized on Markdown everywhere.
Here's what I learned yesterday: I spent a bunch of time trying to figure out a way to store the site background image in a central location, and then have it automatically discovered on every page that needs it (which is only the main landing page, the contact page, and the about page). Previously we used symlinks, but that method broke seemingly because the folder layout within the source repo is different from what actually gets compiled and served. I then tried moving the background image to I also hit a timebox trying to get the title text to look like the way it does with the older version of docsy/hugo (see comments above). I don't know CSS well enough to be able to target that specific element (the title text) on the landing page, and to pass in the configuration needed to shrink down the font. I can revisit this later, or if one of y'all have any ideas I'm all ears. Other issues that I've noticed:
![]() ![]() I'm not sure if these problems only show up when serving locally, or whether they will be resolved when we deploy. We also don't have a "staging" location to deploy the site to verify how the page will look deployed, which is something we should configure. The rest of the site seems to look the way it was previously. I spent too much time on this yesterday and need to get back to HashiCorp work, so I'm putting this aside for now. |
@glarizza I'll try to pick up where you left off later today. |
Closing in favor of #9 |
NOTE: DO NOT MERGE YET; VERSION PINS AND THE GITHUB ACTION HAVEN'T BEEN COMPLETELY UPDATED.
PROBLEM:
The site has been using an older version of Hugo and Docsy. When we tried to add the new Holos page and rendered the site using the newest versions of Hugo/Docsy, lots of formatting and page elements broke.
SOLUTION:
about
page to use row/column shortcodes.row
type on the main homepage so the feature blocks align as columns.OUTCOME:
Executing
hugo serve
locally produces a website with formatting that matches our existing site.